Fix pylint disables

Author: james-d-mitchell

libsemigroups_pybind11/__init__.py

@@ -6,15 +6,42 @@
 #
 # The full license is in the file LICENSE, distributed with this software.
 
-# pylint: disable=no-name-in-module, wrong-import-position, unused-import,
-# pylint: disable=import-error
-
 """
 This package provides the user-facing python part of libsemigroups_pybind11
 """
 
 import pkgconfig
 
+from .detail.dot import _Dot as Dot
+
+from .action import Action, RightAction, LeftAction
+from .adapters import ImageRightAction, ImageLeftAction
+from .congruence import Congruence
+from .froidure_pin import FroidurePin
+from .is_obviously_infinite import is_obviously_infinite
+from .kambites import Kambites
+from .knuth_bendix import KnuthBendix
+from .konieczny import Konieczny
+from .matrix import _Matrix as Matrix, _MatrixKind as MatrixKind
+from .presentation import Presentation, InversePresentation
+from .schreier_sims import SchreierSims
+from .sims import (
+    MinimalRepOrc,
+    RepOrc,
+    Sims1,
+    Sims2,
+    SimsRefinerFaithful,
+    SimsRefinerIdeals,
+)
+from .stephen import Stephen
+from .to import to
+from .todd_coxeter import ToddCoxeter
+from .transf import (
+    PPerm,
+    Perm,
+    Transf,
+)
+
 DISCLAIMER = (
     "(You should not see this message unless you are installing libsemigroups_pybind11 from its "
     "sources. If you are not installing from the sources, please raise an issue at "
@@ -24,7 +51,7 @@
 assert pkgconfig.exists("libsemigroups")
 
 try:
-    from _libsemigroups_pybind11 import (
+    from _libsemigroups_pybind11 import (  # pylint: disable=no-name-in-module
         AhoCorasick,
         BMat8,
         Bipartition,
@@ -70,43 +97,7 @@
         )
     ) from e
 
-from .detail.dot import _Dot as Dot
-
-from .action import Action, RightAction, LeftAction
-from .adapters import ImageRightAction, ImageLeftAction
-
-from .congruence import Congruence
-from .is_obviously_infinite import is_obviously_infinite
-from .kambites import Kambites
-
-from .knuth_bendix import KnuthBendix
-from .matrix import _Matrix as Matrix, _MatrixKind as MatrixKind
-from .presentation import Presentation, InversePresentation
-from .transf import (
-    PPerm,
-    Transf,
-    Perm,
-)
-
-from .todd_coxeter import ToddCoxeter
 
 # The following fools sphinx into thinking that MatrixKind is not an alias.
 MatrixKind.__module__ = __name__
 MatrixKind.__name__ = "MatrixKind"
-
-from .froidure_pin import FroidurePin
-from .schreier_sims import SchreierSims
-
-from .stephen import Stephen
-
-from .to import to
-from .konieczny import Konieczny
-
-from .sims import (
-    Sims1,
-    Sims2,
-    RepOrc,
-    MinimalRepOrc,
-    SimsRefinerFaithful,
-    SimsRefinerIdeals,
-)

libsemigroups_pybind11/action.py

@@ -6,18 +6,15 @@
 #
 # The full license is in the file LICENSE, distributed with this software.
 
-# pylint:disable=no-name-in-module, unused-import,
-# pylint:disable=missing-function-docstring,
-
 """
 This package provides the user-facing python part of libsemigroups_pybind11 for
 the Action class from libsemigroups.
 """
 
-from typing import Any, Union, Iterator, TypeVar as _TypeVar
+from typing import Iterator, TypeVar as _TypeVar
 from typing_extensions import Self as _Self
 
-from _libsemigroups_pybind11 import (
+from _libsemigroups_pybind11 import (  # pylint: disable=no-name-in-module
     BMat8 as _BMat8,
     LeftActionBMat8BMat8 as _LeftActionBMat8BMat8,
     LeftActionPPerm1List as _LeftActionPPerm1List,
@@ -265,6 +262,7 @@ def __contains__(self: _Self, pt: Point) -> bool:
 
     @_copydoc(_RightActionPPerm1PPerm1.generators)
     def generators(self: _Self) -> Iterator[Element]:
+        # pylint: disable=missing-function-docstring
         return map(
             _to_py,
             _to_cxx(self).generators(),

libsemigroups_pybind11/adapters.py

@@ -6,18 +6,15 @@
 #
 # The full license is in the file LICENSE, distributed with this software.
 
-# pylint:disable=no-name-in-module, unused-import
-
 """
 This package provides the user-facing python part of libsemigroups_pybind11 for
 various adapters from libsemigroups.
 """
 
-from typing import Any, Union, Iterator, TypeVar as _TypeVar, List
-
+from typing import TypeVar as _TypeVar
 from typing_extensions import Self as _Self
 
-from _libsemigroups_pybind11 import (
+from _libsemigroups_pybind11 import (  # pylint: disable=no-name-in-module,unused-import
     # TODO Transf
     # TODO other pperms
     BMat8 as _BMat8,
@@ -72,7 +69,9 @@ def __init__(self: _Self, *args, point=None, element=None) -> None:
         if _to_cxx(self) is not None:
             return
         if len(args) != 0:
-            raise ValueError(f"expected 0 positional arguments, but found {len(args)}")
+            raise ValueError(
+                f"expected 0 positional arguments, but found {len(args)}"
+            )
         self.py_template_params = (
             type(_to_cxx(element)),
             type(_to_cxx(point)),
@@ -120,7 +119,11 @@ def __call__(self: _Self, pt: Point, x: Element) -> Point:
 
 _copy_cxx_mem_fns(_ImageRightActionPPerm1PPerm1, ImageRightAction)
 
-for _type in ImageRightAction._py_template_params_to_cxx_type.values():  # pylint:disable=protected-access
+for (
+    _type
+) in (
+    ImageRightAction._py_template_params_to_cxx_type.values()
+):  # pylint:disable=protected-access
     _register_cxx_wrapped_type(_type, ImageRightAction)
 
 

libsemigroups_pybind11/aho_corasick.py

@@ -5,14 +5,15 @@
 # Distributed under the terms of the GPL license version 3.
 #
 # The full license is in the file LICENSE, distributed with this software.
-# pylint:disable=no-name-in-module, unused-import
+
 """
 This module contains various helper functions for the class :any:`AhoCorasick`.
 These functions could be functions of :any:`AhoCorasick` but they only use
 public member functions of :any:`AhoCorasick`, and so they are declared
 as free functions instead.
 """
-from _libsemigroups_pybind11 import (
+
+from _libsemigroups_pybind11 import (  # pylint: disable=no-name-in-module,unused-import
     aho_corasick_add_word as add_word,
     rm_word,
     traverse_word,

libsemigroups_pybind11/bipartition.py

@@ -6,14 +6,12 @@
 #
 # The full license is in the file LICENSE, distributed with this software.
 
-# pylint: disable=no-name-in-module, invalid-name, unused-import, fixme
-
 """
 This package provides the user-facing python part of libsemigroups_pybind11 for
 the libsemigroups::bipartition namespace from libsemigroups.
 """
 
-from _libsemigroups_pybind11 import (
+from _libsemigroups_pybind11 import (  # pylint: disable=no-name-in-module,unused-import
     bipartition_underlying_partition as underlying_partition,
     bipartition_one as one,
     Bipartition,

libsemigroups_pybind11/blocks.py

@@ -6,14 +6,12 @@
 #
 # The full license is in the file LICENSE, distributed with this software.
 
-# pylint: disable=no-name-in-module, invalid-name, unused-import, fixme
-
 """
 This package provides the user-facing python part of ``libsemigroups_pybind11`` for
 the ``libsemigroups::blocks`` namespace from ``libsemigroups``.
 """
 
-from _libsemigroups_pybind11 import (
+from _libsemigroups_pybind11 import (  # pylint: disable=no-name-in-module,unused-import
     blocks_underlying_partition as underlying_partition,
     Blocks,
 )

libsemigroups_pybind11/bmat8.py

@@ -6,13 +6,11 @@
 #
 # The full license is in the file LICENSE, distributed with this software.
 
-# pylint:disable=no-name-in-module, unused-import
-
 """
 This module contains the helper functions from ``libsemigroups_pybind11.bmat8``.
 """
 
-from _libsemigroups_pybind11 import (
+from _libsemigroups_pybind11 import (  # pylint: disable=no-name-in-module,unused-import
     bmat8_one as one,
     random,
     transpose,

libsemigroups_pybind11/congruence.py

@@ -6,20 +6,16 @@
 #
 # The full license is in the file LICENSE, distributed with this software.
 
-# pylint: disable=no-name-in-module, invalid-name, unused-import, fixme
-# pylint: disable=protected-access, missing-function-docstring
-# pylint: disable=missing-class-docstring
-
 """
 This page contains the documentation for various helper functions for
 manipulating :any:`Congruence` objects. All such functions are contained in
 the submodule ``congruence``.
 """
 
-from typing import List, Iterator, Union
-from typing_extensions import Self
+from typing import List, Union
+from typing_extensions import Self as _Self
 
-from _libsemigroups_pybind11 import (
+from _libsemigroups_pybind11 import (  # pylint: disable=no-name-in-module,unused-import
     CongruenceString as _CongruenceString,
     CongruenceWord as _CongruenceWord,
     congruence_non_trivial_classes as _congruence_non_trivial_classes,
@@ -43,7 +39,7 @@
 )
 
 
-class Congruence(_CongruenceCommon):
+class Congruence(_CongruenceCommon):  # pylint: disable=missing-class-docstring
     __doc__ = _CongruenceWord.__doc__
 
     _py_template_params_to_cxx_type = {
@@ -61,7 +57,7 @@ class Congruence(_CongruenceCommon):
     _all_wrapped_cxx_types = {*_py_template_params_to_cxx_type.values()}
 
     @_copydoc(_CongruenceWord.__init__)
-    def __init__(self: Self, *args, **kwargs) -> None:
+    def __init__(self: _Self, *args, **kwargs) -> None:
         super().__init__(*args, **kwargs)
         if _to_cxx(self) is not None:
             return
@@ -75,7 +71,9 @@ def __init__(self: Self, *args, **kwargs) -> None:
                 )
         self.init_cxx_obj(*args)
 
-    def get(self: Self, t: type) -> Union[_Kambites, _KnuthBendix, _ToddCoxeter]:
+    def get(
+        self: _Self, t: type
+    ) -> Union[_Kambites, _KnuthBendix, _ToddCoxeter]:
         """
         :sig=(self: Congruence, t: type) -> Kambites | KnuthBendix | ToddCoxeter:
         Returns the *t* instance used to compute the congruence (if any).
@@ -105,7 +103,7 @@ def get(self: Self, t: type) -> Union[_Kambites, _KnuthBendix, _ToddCoxeter]:
             f", but found {t}"
         )
 
-    def has(self: Self, t: type) -> bool:
+    def has(self: _Self, t: type) -> bool:
         """
         :sig=(self: Congruence, t: type) -> bool:
 

libsemigroups_pybind11/detail/congruence_common.py

@@ -6,9 +6,6 @@
 #
 # The full license is in the file LICENSE, distributed with this software.
 
-# pylint: disable=no-name-in-module
-# BECAUSE: pylint can't find any imports from _libsemigroups_pybind11
-
 """
 This submodule collects some common aspects of the classes Congruence,
 Kambites, KnuthBendix, and ToddCoxeter.
@@ -17,7 +14,9 @@
 from typing import List
 from typing_extensions import Self
 
-from _libsemigroups_pybind11 import congruence_kind as _congruence_kind
+from _libsemigroups_pybind11 import (  # pylint: disable=no-name-in-module
+    congruence_kind as _congruence_kind,
+)
 
 from libsemigroups_pybind11.presentation import Presentation as _Presentation
 

libsemigroups_pybind11/detail/cxx_wrapper.py

@@ -6,9 +6,6 @@
 #
 # The full license is in the file LICENSE, distributed with this software.
 
-# pylint: disable=no-name-in-module
-# BECAUSE: pylint can't find any imports from _libsemigroups_pybind11
-
 """
 This package provides some functions and a class CxxWrapper to help wrap
 multiple C++ types into a single python type. I.e. to wrap a C++ class template
@@ -23,7 +20,9 @@
 from typing import Any, Callable
 from typing_extensions import Self
 
-from _libsemigroups_pybind11 import UNDEFINED as _UNDEFINED
+from _libsemigroups_pybind11 import (  # pylint: disable=no-name-in-module
+    UNDEFINED as _UNDEFINED,
+)
 
 pybind11_type = type(_UNDEFINED)
 
@@ -122,7 +121,9 @@ def __getattr__(self: Self, name: str):
             def cxx_fn_wrapper(*args) -> Any:
                 if len(args) == 1 and isinstance(args[0], list):
                     args = args[0]
-                    return getattr(self._cxx_obj, name)([to_cxx(x) for x in args])
+                    return getattr(self._cxx_obj, name)(
+                        [to_cxx(x) for x in args]
+                    )
                 return getattr(self._cxx_obj, name)(*(to_cxx(x) for x in args))
 
             return cxx_fn_wrapper
@@ -167,9 +168,9 @@ def init_cxx_obj(self: Self, *args) -> None:
         defined.
         """
         assert self.py_template_params is not None
-        self._cxx_obj = self._py_template_params_to_cxx_type[self.py_template_params](
-            *(to_cxx(x) for x in args)
-        )
+        self._cxx_obj = self._py_template_params_to_cxx_type[
+            self.py_template_params
+        ](*(to_cxx(x) for x in args))
 
 
 # TODO proper annotations
@@ -185,7 +186,9 @@ def cxx_mem_fn_wrapper(self, *args):
         # TODO move the first if-clause into to_cxx?
         if len(args) == 1 and isinstance(args[0], list):
             args = [[to_cxx(x) for x in args[0]]]
-        result = getattr(to_cxx(self), cxx_mem_fn.__name__)(*(to_cxx(x) for x in args))
+        result = getattr(to_cxx(self), cxx_mem_fn.__name__)(
+            *(to_cxx(x) for x in args)
+        )
         if result is to_cxx(self):
             return self
         if type(result) in _CXX_WRAPPED_TYPE_TO_PY_TYPE:
@@ -227,7 +230,9 @@ def copy_cxx_mem_fns(cxx_class: pybind11_type, py_class: CxxWrapper) -> None:
     that call the cxx member function on the _cxx_obj.
     """
     for py_meth_name in dir(cxx_class):
-        if (not py_meth_name.startswith("_")) and py_meth_name not in dir(py_class):
+        if (not py_meth_name.startswith("_")) and py_meth_name not in dir(
+            py_class
+        ):
             setattr(
                 py_class,
                 py_meth_name,