Skip to content

Commit 529edd3

Browse files
author
jsing
committed
Revise regress for ascii/text to ASN.1 object conversion rewrite.
1 parent 6845433 commit 529edd3

File tree

1 file changed

+10
-58
lines changed

1 file changed

+10
-58
lines changed

src/regress/lib/libcrypto/asn1/asn1object.c

Lines changed: 10 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* $OpenBSD: asn1object.c,v 1.5 2022/03/19 16:23:17 jsing Exp $ */
1+
/* $OpenBSD: asn1object.c,v 1.6 2022/03/19 17:37:10 jsing Exp $ */
22
/*
33
* Copyright (c) 2017, 2021, 2022 Joel Sing <jsing@openbsd.org>
44
*
@@ -118,18 +118,6 @@ struct asn1_object_test asn1_object_tests[] = {
118118
},
119119
.der_len = 5,
120120
},
121-
{
122-
.oid = "2.5 4.10",
123-
.txt = "organizationName",
124-
.content = {
125-
0x55, 0x04, 0x0a,
126-
},
127-
.content_len = 3,
128-
.der = {
129-
0x06, 0x03, 0x55, 0x04, 0x0a,
130-
},
131-
.der_len = 5,
132-
},
133121
{
134122
.oid = "2.5.0.0",
135123
.txt = "2.5.0.0",
@@ -170,63 +158,23 @@ struct asn1_object_test asn1_object_tests[] = {
170158
},
171159
{
172160
.oid = "2.00005.0000000000004.10",
173-
.content = {
174-
0x55, 0x04, 0x0a,
175-
},
176-
.content_len = 3,
177-
.der = {
178-
0x06, 0x03, 0x55, 0x04, 0x0a,
179-
},
180-
.der_len = 5,
181-
.want_error = 0, /* XXX */
161+
.want_error = ASN1_R_INVALID_NUMBER,
182162
},
183163
{
184164
.oid = "2..5.4.10",
185-
.content = {
186-
0x50, 0x05, 0x04, 0x0a,
187-
},
188-
.content_len = 4,
189-
.der = {
190-
0x06, 0x04, 0x50, 0x05, 0x04, 0x0a,
191-
},
192-
.der_len = 6,
193-
.want_error = 0, /* XXX */
165+
.want_error = ASN1_R_INVALID_NUMBER,
194166
},
195167
{
196168
.oid = "2.5..4.10",
197-
.content = {
198-
0x55, 0x00, 0x04, 0x0a,
199-
},
200-
.content_len = 4,
201-
.der = {
202-
0x06, 0x04, 0x55, 0x00, 0x04, 0x0a,
203-
},
204-
.der_len = 6,
205-
.want_error = 0, /* XXX */
169+
.want_error = ASN1_R_INVALID_NUMBER,
206170
},
207171
{
208172
.oid = "2.5.4..10",
209-
.content = {
210-
0x55, 0x04, 0x00, 0x0a,
211-
},
212-
.content_len = 4,
213-
.der = {
214-
0x06, 0x04, 0x55, 0x04, 0x00, 0x0a,
215-
},
216-
.der_len = 6,
217-
.want_error = 0, /* XXX */
173+
.want_error = ASN1_R_INVALID_NUMBER,
218174
},
219175
{
220176
.oid = "2.5.4.10.",
221-
.content = {
222-
0x55, 0x04, 0x0a,
223-
},
224-
.content_len = 3,
225-
.der = {
226-
0x06, 0x03, 0x55, 0x04, 0x0a,
227-
},
228-
.der_len = 5,
229-
.want_error = 0, /* XXX */
177+
.want_error = ASN1_R_INVALID_NUMBER,
230178
},
231179
{
232180
.oid = "3.5.4.10",
@@ -244,6 +192,10 @@ struct asn1_object_test asn1_object_tests[] = {
244192
.oid = "2",
245193
.want_error = ASN1_R_MISSING_SECOND_NUMBER,
246194
},
195+
{
196+
.oid = "2.5 4.10",
197+
.want_error = ASN1_R_INVALID_SEPARATOR,
198+
},
247199
{
248200
.oid = "2,5,4,10",
249201
.want_error = ASN1_R_INVALID_SEPARATOR,

0 commit comments

Comments
 (0)