Asymmetry between SwarmEvent::ConnectionEstablished and SwarmEvent::ConnectionClosed

[nazar-pc]

Just had a bug in the app due to SwarmEvent::ConnectionClosed happening much more often than SwarmEvent::ConnectionEstablished. I guess this happens due to connection errors, but I'm still surprised that connections are closing before being established.

Any suggestions how to account for this properly?

[mxinden]

I am surprised that this is the case. I would expect the number of ConnectionClosed and ConnectionEstablished events to only differ by the number of currently established connections. Can you provide a way to reproduce this @nazar-pc?

[mxinden]

Are you using Swarm::ban_peer_id @nazar-pc?

[nazar-pc]

Yes and started using relatively recently

[mxinden]

@nazar-pc can you still reproduce these failures with latest master or the v0.51.0 release? The banning logic and the connection state reporting has been refactored with #3328, thus I wonder whether the issue you are seeing is still occurring.

[nazar-pc]

I added some additional loud logging in case this happens and didn't see anything recently, so maybe it is fixed indeed (running quite recent master branch). Will keep an eye on it, thanks!

[mxinden]

Thanks @nazar-pc!