Skip to content

PeerId: Why protobuf wrapped as multihash? #3079

Closed Answered by thomaseizinger
yojoe asked this question in Q&A
Discussion options

You must be logged in to vote

In principle, you are right. There is room for optimisation.

This would have to be discussed on a spec level (see https://github.com/libp2p/specs).

Especially go-libp2p has many deployments outside of our control so any change would have to be rolled out carefully and in a backwards-compatible way.

Personally, I am not a huge fan of protobuf but I see the benefit when it comes to describing protocol messages. For simpler data types like PeerId, I'd be in favor of trying to remove it.

We'd also have to figure out how this interacts with https://github.com/libp2p/specs/blob/master/RFC/0001-text-peerid-cid.md which we are yet to support in rust-libp2p. See #2259.

Replies: 1 comment 2 replies

Comment options

You must be logged in to vote
2 replies
@yojoe
Comment options

@yojoe
Comment options

Answer selected by yojoe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
2 participants