Cleanup API, remove deprecation, stuff

Author: AndrianBdn

README.md

@@ -102,6 +102,12 @@ aws ec2 run-instances \
 
 For more information, see the [AWS EC2 Instance Metadata Options documentation](https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_InstanceMetadataOptionsRequest.html).
 
+## Note on propagation-related fields
+
+When you update records in AWS Route53, changes first propagate internally across AWS’s DNS servers before becoming visible to the public. This internal step usually finishes within seconds, but may take more in rare cases, and can be waited on when `WaitForPropagation` is enabled. *It is different from normal DNS propagation, which depends on TTL and external caching.*
+
+See [Change Propagation to Route 53 DNS Servers](https://docs.aws.amazon.com/Route53/latest/APIReference/API_ChangeResourceRecordSets.html#API_ChangeResourceRecordSets_RequestSyntax:~:text=Change%20Propagation%20to%20Route%2053%20DNS%20Servers).
+
 ## Contributing
 
 Contributions are welcome! Please ensure that:

client.go

@@ -92,9 +92,8 @@ func (p *Provider) init(ctx context.Context) {
 		p.MaxRetries = 5
 	}
 
-	p.MaxWaitDur *= time.Second
-	if p.MaxWaitDur == 0 {
-		p.MaxWaitDur = time.Minute
+	if p.MaxWaitDuration == 0 {
+		p.MaxWaitDuration = time.Minute
 	}
 
 	opts := make([]func(*config.LoadOptions) error, 0)
@@ -105,9 +104,6 @@ func (p *Provider) init(ctx context.Context) {
 	)
 
 	profile := p.Profile
-	if profile == "" {
-		profile = p.AWSProfile
-	}
 
 	if profile != "" {
 		opts = append(opts, config.WithSharedConfigProfile(profile))
@@ -119,9 +115,6 @@ func (p *Provider) init(ctx context.Context) {
 
 	if p.AccessKeyId != "" && p.SecretAccessKey != "" {
 		token := p.SessionToken
-		if token == "" {
-			token = p.Token
-		}
 
 		opts = append(
 			opts,
@@ -407,7 +400,7 @@ func (p *Provider) applyChange(ctx context.Context, input *r53.ChangeResourceRec
 
 		// Wait for the RecordSetChange status to be "INSYNC"
 		waiter := r53.NewResourceRecordSetsChangedWaiter(p.client)
-		err = waiter.Wait(ctx, changeInput, p.MaxWaitDur)
+		err = waiter.Wait(ctx, changeInput, p.MaxWaitDuration)
 		if err != nil {
 			return err
 		}

client_test.go

@@ -376,15 +376,15 @@ func TestMaxWaitDur(t *testing.T) {
 		{
 			name:     "custom",
 			input:    120,
-			expected: 120 * time.Second,
+			expected: 120,
 		},
 	}
 
 	for _, c := range cases {
 		t.Run(c.name, func(t *testing.T) {
-			provider := Provider{MaxWaitDur: c.input}
+			provider := Provider{MaxWaitDuration: c.input}
 			provider.init(context.TODO())
-			actual := provider.MaxWaitDur
+			actual := provider.MaxWaitDuration
 			if actual != c.expected {
 				t.Errorf("expected %d, got %d", c.expected, actual)
 			}

provider.go

@@ -19,12 +19,6 @@ type Provider struct {
 	// environment variable.
 	Region string `json:"region,omitempty"`
 
-	// AWSProfile is the AWS Profile to use. If not set, it will use
-	// AWS_PROFILE environment variable.
-	//
-	// Deprecated: Use Profile instead
-	AWSProfile string `json:"aws_profile,omitempty"`
-
 	// AWSProfile is the AWS Profile to use. If not set, it will use
 	// AWS_PROFILE environment variable.
 	Profile string `json:"profile,omitempty"`
@@ -37,12 +31,6 @@ type Provider struct {
 	// AWS_SECRET_ACCESS_KEY environment variable.
 	SecretAccessKey string `json:"secret_access_key,omitempty"`
 
-	// Token is the AWS Session Token to use. If not set, it will use
-	// AWS_SESSION_TOKEN environment variable.
-	//
-	// Deprecated: Use SessionToken instead.
-	Token string `json:"token,omitempty"`
-
 	// SessionToken is the AWS Session Token to use. If not set, it will use
 	// AWS_SESSION_TOKEN environment variable.
 	SessionToken string `json:"session_token,omitempty"`
@@ -51,15 +39,16 @@ type Provider struct {
 	// fails. If not set, it will use 5 retries.
 	MaxRetries int `json:"max_retries,omitempty"`
 
-	// MaxWaitDur is the maximum amount of time in seconds to wait for a record
-	// to be propagated. If not set, it will 1 minute.
-	MaxWaitDur time.Duration `json:"max_wait_dur,omitempty"`
+	// MaxWaitDuration is the maximum amount of time to wait for a record
+	// to be propagated within AWS infrastructure. Default is 1 minute.
+	MaxWaitDuration time.Duration `json:"max_wait_duration,omitempty"`
 
 	// WaitForPropagation if set to true, it will wait for the record to be
-	// propagated before returning.
+	// propagated within AWS infrastructure before returning. This is not related
+	// to DNS propagation, that could take much longer.
 	WaitForPropagation bool `json:"wait_for_propagation,omitempty"`
 
-	// hostedZoneID is the ID of the hosted zone to use. If not set, it will
+	// HostedZoneID is the ID of the hosted zone to use. If not set, it will
 	// be discovered from the zone name.
 	//
 	// This option should contain only the ID; the "/hostedzone/" prefix