Skip to content

strip _acme-challenge. prefix should be discouraged #5

@zhangyoufu

Description

@zhangyoufu

There is one more DNS-based ACME challenge type dns-account-01 being introduced. It's using DNS record "_" || base32(SHA-256(<ACCOUNT_URL>)[0:10]) || "._acme-challenge".


When looking up ACME-DNS account via domain name, libdns/acmedns strips _acme-challenge. prefix before performing the lookup.

acmedns/provider.go

Lines 67 to 72 in 55d190b

func (p *Provider) selectAccount(zone string, name string) (*account, error) {
if p.Configs != nil {
domain := libdns.AbsoluteName(name, zone)
domain = strings.Trim(domain, ".")
domain = strings.TrimPrefix(domain, acmePrefix)
config, found := p.Configs[domain]

This stripping should be discouraged, to avoid inconsistency that dns-01 challange type needs to be configured in example.com entry while dns-account-01 challenge type needs to be configured in _XXXXXXXXXXXXXXXX._acme-challenge.example.com.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions