Broken types

[TrejGun]

Describe the bug

How to fix

rollback types for

useFactory?: (...args: unknown[]) => RedisModuleOptions | Promise<RedisModuleOptions>;

it should be any not unknown

[TrejGun]

I also want to share some feedback:

First of all thanks for your work

While I understand that there was a reason to make all these changes the interface of v9 was better. I especially miss decorators.

I tried to migrate to the new version but the health indicator is not updated and useFactory has wrong typings so I decided to stay on v9 for now

[lluiscab]

Just tried to update to v10 and found the same issue. I'll postpone updating until this issue is resolved.

[ninja-]

I decided to ignore the error like that until the fix is there - since I am doing a big version jump and there are lot of related dependencies, I would rather not spend time checking how compatible they are with v9 right now

everything else works :)

    RedisModule.forRootAsync({
      // @ts-expect-error
      useFactory: async (config: ConfigService) => ({
        readyLog: true,
        config: {
          host: config.get('REDIS_HOST'),
          port: +config.get('REDIS_PORT'),
          password: '',
        },
      }) as any,
      imports: [ConfigModule],
      inject: [ConfigService],
    }),

[KlausNie]

I'm doing something similar to @ninja-

  RedisModule.forRootAsync({
    useFactory: ((configService: ConfigService) => {
      return redisConfig(configService);
    } ) as (...args: unknown[]) => Promise<RedisModuleOptions>,
    inject: [ConfigService],
  }),

I'm just curious what prompted this change?
I'm guessing any is not very restrictive

[MaksimKiselev]

Same issue

[iamkanguk97]

I got the same issue! Can I get some feedback?

[R11baka]

@iamkanguk97 can you provide steps to reproduce ?can you share your code for useFactory ?
because I do not have issue

[liaoliaots]

This bug has been fixed(#554), please wait for the next major release: nestjs-redis v11 with new features(Using an existing Redis instance, provide custom loggerContext and loggerTimestamp, some hooks used for Transforming Arguments & Replies, etc..), and new InjectRedis & InjectCluster decorators.

[iamkanguk97]

@R11baka Hello! I'm sorry for the late reply.

export interface RedisModuleAsyncOptions extends Pick<ModuleMetadata, 'imports'> {
    useFactory?: (...args: unknown[]) => RedisModuleOptions | Promise<RedisModuleOptions>;
    useClass?: Type<RedisOptionsFactory>;
    useExisting?: Type<RedisOptionsFactory>;
    inject?: InjectionToken[] | OptionalFactoryDependency[];
    extraProviders?: Provider[];
}
export interface RedisOptionsFactory {
    createRedisOptions: () => RedisModuleOptions | Promise<RedisModuleOptions>;
}

This is my useFactory code. Also, I'm using @liaoliaots/nestjs-redis 10 version and nest version is also 10.
I think you are not using version 10 of nestjs-redis. Was this answered?

For Reference, I temporarily solved it as follows:

// eslint-disable-next-line @typescript-eslint/ban-ts-comment
      // @ts-expect-error
      useFactory: (configService: ConfigService): RedisModuleOptions => {
        const config = getAppConfig(configService);
        const { HOST, PORT, PASSWORD } = config.REDIS;

        return {
          config: {
            host: HOST,
            port: +PORT,
            password: PASSWORD,
          },
          readyLog: true,
          errorLog: true,
        };
      },

Hope you have a good day.
Thanks.

[liaoliaots]

This bug has been fixed(#554), please wait for the next major release: nestjs-redis v11 with new features(Using an existing Redis instance, provide custom loggerContext and loggerTimestamp, some hooks used for Transforming Arguments & Replies, etc..), and new InjectRedis & InjectCluster decorators.

And support node-redis v4 (redis & cluster), update redis-health lib.
And write tests to ensure the robustness of the lib.
At that time, version 10 will be marked as deprecated.