removing code duplication, cleanup some code

Author: jglambed

src/kafka-topics/list/topics-list.controller.js

@@ -1,5 +1,4 @@
 angularAPP.controller('KafkaTopicsListCtrl', function ($scope, $rootScope, $location, $routeParams, $mdToast, $log, KafkaRestProxyFactory, toastFactory, env) {
- $rootScope.timesCalled = 1;
   $log.info("Starting kafka-topics controller : list (getting topic info)");
   toastFactory.hideToast();
 
@@ -75,7 +74,7 @@ angularAPP.controller('KafkaTopicsListCtrl', function ($scope, $rootScope, $loca
       }
     });
 
-    return doLalbels(counts.replications, 'Replication') + ' \u2A2F ' + doLalbels(counts.partitions, 'Partition');
+    return doLabels(counts.replications, 'Replication') + ' \u2A2F ' + doLabels(counts.partitions, 'Partition');
   }
 
 
@@ -124,7 +123,7 @@ function getLeftListTopics() {
     });
     }
 
-  function doLalbels(count, name) {
+  function doLabels(count, name) {
     if (count == 0) return 'None ' + name;
     else if (count == 1) return '1 ' + name;
     else return count + ' ' + name +'s';

src/kafka-topics/view/templates/withConfiguration.html

@@ -1,7 +1,7 @@
 <!-- Custom rendering for Config overrides -->
   <md-tab-body>
     <md-content class="md-padding">
-        <table class="flat-table" >
+        <table class="flat-table"  ng-if ="getExtraConfig(topicName) !== ''" >
           <thead>
           <tr>
             <th class="td-center">Comfiguration</th>
@@ -34,7 +34,7 @@
           </tr>
           </tbody>
           </table>
-        <div class="container-fluid-centered ng-scope" ng-if ="hasExtraConfig(topicName) == ''" style="height: 352px;">
+        <div class="container-fluid-centered ng-scope" ng-if ="getExtraConfig(topicName) == ''" style="height: 352px;">
             <div class="row-fluid">
                 <div class="centering text-center">
                   This topic retains the default configuration

src/kafka-topics/view/view.controller.js

@@ -109,19 +109,12 @@ angularAPP.controller('ViewTopicCtrl', function ($scope, $rootScope, $filter, $r
     originatorEv = null;
   };
 
-  $scope.hasExtraConfig = function (topicName) {
-    var topicDetails = KafkaRestProxyFactory.isNormalTopic(topicName) ? $rootScope.topicDetails : $rootScope.controlTopicDetails;
-    var extra = KafkaRestProxyFactory.hasExtraConfig(topicName, topicDetails);
-    if (extra != '') {
-      // $log.debug("Topic details " + topicName + " HAS EXTRA CONFIG " + extra);
-    }
-    return extra;
-  };
-
   $scope.getExtraConfig = function (topicName) {
     var topicDetails = KafkaRestProxyFactory.isNormalTopic(topicName) ? $rootScope.topicDetails : $rootScope.controlTopicDetails;
     var extra = KafkaRestProxyFactory.hasExtraConfig(topicName, topicDetails);
+    if (extra)
     return JSON.parse(extra);
+    else return ''
   };
 
   $scope.getDefautConfigValue = function (configKey) {