Skip to content

Commit 1562f0f

Browse files
committed
Add todo
1 parent a44db54 commit 1562f0f

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

conditioner.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1474,6 +1474,7 @@ struct PixArtCLIPEmbedder : public Conditioner {
14741474
chunk_hidden_states->ne[0],
14751475
ggml_nelements(hidden_states) / chunk_hidden_states->ne[0]);
14761476
} else {
1477+
// TODO: maybe precompute embeddings for <pad> token and fill with that instead? (proper uncond)
14771478
hidden_states = ggml_new_tensor_2d(work_ctx, GGML_TYPE_F32, 4096, chunk_len);
14781479
ggml_set_f32(hidden_states, 0.f);
14791480
t5_attn_mask = ggml_new_tensor_1d(work_ctx, GGML_TYPE_F32, chunk_len);

0 commit comments

Comments
 (0)