-
Notifications
You must be signed in to change notification settings - Fork 303
Submitting Pull Requests
Ben Cipollini edited this page Mar 13, 2014
·
10 revisions
For all new features and any major changes (including class or function additions) for bugfixes, we require documentation to be submitted along with code changes.
For comments, we follow Google's Python Style Guide, which contain docstring formatting instructions.
We use docstrings & comments for each of the following
- New modules / apps: docstring in the module's
__init__.py
, explaining the high-level need, design, and dependencies. - New files: docstring at the top of the file defining what lives inside, and any overall design.
- New functions/classes: docstring for each
- Inline: as needed
We require unit tests for all new features, selenium-based in-browser tests for front-end testing, and ecosystem tests
to tests changes to KA Lite's interaction with our central data repository.