-
Notifications
You must be signed in to change notification settings - Fork 200
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
running the very same test which work for 1.1.10.post
but crash with latest 1.1.11
To Reproduce
__________________ test_maddrs[host_maddrs1-expected_maddrs1] __________________
host_maddrs = ['/ip4/127.0.0.1/tcp/0']
expected_maddrs = ['/ip4/127.0.0.1/tcp/0']
@mock.patch.dict(os.environ, {"HIVEMIND_MEMORY_SHARING_STRATEGY": "file_descriptor"}, clear=True)
@pytest.mark.parametrize(
("host_maddrs", "expected_maddrs"),
[(None, ["/ip4/0.0.0.0/tcp/0", "/ip4/0.0.0.0/udp/0/quic"]), (["/ip4/127.0.0.1/tcp/0"], ["/ip4/127.0.0.1/tcp/0"])],
)
def test_maddrs(host_maddrs, expected_maddrs):
"""Test that the multiple addresses are correctly assigned."""
> strategy = HivemindStrategy(target_batch_size=1, host_maddrs=host_maddrs)
tests/test_strategy.py:228:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
src/lightning_hivemind/strategy.py:188: in __init__
self.dht = hivemind.DHT(
/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/site-packages/hivemind/dht/dht.py:87: in __init__
self.run_in_background(await_ready=await_ready)
/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/site-packages/hivemind/dht/dht.py:148: in run_in_background
self.wait_until_ready(timeout)
/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/site-packages/hivemind/dht/dht.py:151: in wait_until_ready
self._ready.result(timeout=timeout)
/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/site-packages/hivemind/utils/mpfuture.py:254: in result
return super().result(timeout)
/opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/concurrent/futures/_base.py:458: in result
return self.__get_result()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = None
def __get_result(self):
if self._exception:
try:
> raise self._exception
E hivemind.p2p.p2p_daemon_bindings.utils.P2PDaemonError: Daemon failed to start: /opt/hostedtoolcache/Python/3.10.17/x64/lib/python3.10/site-packages/hivemind/hivemind_cli/p2pd: 2: Syntax error: "(" unexpected
Environment
the full CI trace: https://github.com/Lightning-Universe/lightning-Hivemind/actions/runs/14857144975/job/41713070764?pr=80
If the script doesn't work, please report pytorch and numpy versions manually. We also encourage you to include any additional information that you believe can help us solve the issue.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working