forked from austintgriffith/burner-wallet
-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
I noticed those lines of codes in parseBlocks:
plasma-burner-wallet/src/App.js
Lines 532 to 540 in 75e3e38
| let block = await web3.eth.getBlock(parseBlock) | |
| let updatedTxs = false | |
| if(block){ | |
| let transactions = block.transactions | |
| //console.log("transactions",transactions) | |
| for(let t in transactions){ | |
| //console.log("TX",transactions[t]) | |
| let tx = await web3.eth.getTransaction(transactions[t]) |
web3.eth.getBlock allows to retrieve all transaction objects by enabling the optional parameter returnTransactionObjects
This would allow the burner wallet to make a single http request per block, instead of one http request per transaction. I understand that right now the number of transactions per block is not huge, but still querying for all transactions at once should be the preferred approach.
Note: I can make a bounty out of this, just asking for now
Metadata
Metadata
Assignees
Labels
No labels