refactor: Simplify keyboard event handling by replacing string representation with keycode in KeyboardEventHandler

Author: lijy91

src/keyboard_monitor.cpp

@@ -3,20 +3,20 @@
 namespace nativeapi {
 
 KeyboardEventHandler::KeyboardEventHandler(
-    std::function<void(const std::string&)> onKeyPressedCallback,
-    std::function<void(const std::string&)> onKeyReleasedCallback)
+    std::function<void(int)> onKeyPressedCallback,
+    std::function<void(int)> onKeyReleasedCallback)
     : onKeyPressedCallback_(onKeyPressedCallback),
       onKeyReleasedCallback_(onKeyReleasedCallback) {}
 
-void KeyboardEventHandler::OnKeyPressed(const std::string& key) {
+void KeyboardEventHandler::OnKeyPressed(int keycode) {
   if (onKeyPressedCallback_) {
-    onKeyPressedCallback_(key);
+    onKeyPressedCallback_(keycode);
   }
 }
 
-void KeyboardEventHandler::OnKeyReleased(const std::string& key) {
+void KeyboardEventHandler::OnKeyReleased(int keycode) {
   if (onKeyReleasedCallback_) {
-    onKeyReleasedCallback_(key);
+    onKeyReleasedCallback_(keycode);
   }
 }
 

src/keyboard_monitor.h

@@ -10,19 +10,18 @@ namespace nativeapi {
 class KeyboardEventHandler {
  public:
   // Constructor that takes callbacks for keyboard events
-  KeyboardEventHandler(
-      std::function<void(const std::string&)> onKeyPressedCallback,
-      std::function<void(const std::string&)> onKeyReleasedCallback);
+  KeyboardEventHandler(std::function<void(int)> onKeyPressedCallback,
+                       std::function<void(int)> onKeyReleasedCallback);
 
   // Handle key pressed event
-  void OnKeyPressed(const std::string& key);
+  void OnKeyPressed(int keycode);
 
   // Handle key released event
-  void OnKeyReleased(const std::string& key);
+  void OnKeyReleased(int keycode);
 
  private:
-  std::function<void(const std::string&)> onKeyPressedCallback_;
-  std::function<void(const std::string&)> onKeyReleasedCallback_;
+  std::function<void(int)> onKeyPressedCallback_;
+  std::function<void(int)> onKeyReleasedCallback_;
 };
 
 class KeyboardMonitor {

src/keyboard_monitor_macos.mm

@@ -41,22 +41,10 @@ static CGEventRef keyboardEventCallback(CGEventTapProxy proxy,
   // Get the key code
   CGKeyCode keyCode = (CGKeyCode)CGEventGetIntegerValueField(event, kCGKeyboardEventKeycode);
 
-  // Convert key code to string representation
-  UniCharCount actualStringLength = 0;
-  UniChar unicodeString[4];
-  CGEventKeyboardGetUnicodeString(event, 4, &actualStringLength, unicodeString);
-
-  if (actualStringLength > 0) {
-    std::string keyStr(actualStringLength, 0);
-    for (UniCharCount i = 0; i < actualStringLength; ++i) {
-      keyStr[i] = static_cast<char>(unicodeString[i]);
-    }
-
-    if (type == kCGEventKeyDown) {
-      eventHandler->OnKeyPressed(keyStr);
-    } else if (type == kCGEventKeyUp) {
-      eventHandler->OnKeyReleased(keyStr);
-    }
+  if (type == kCGEventKeyDown) {
+    eventHandler->OnKeyPressed(keyCode);
+  } else if (type == kCGEventKeyUp) {
+    eventHandler->OnKeyReleased(keyCode);
   }
 
   return event;