register every script as own command

Author: alexcoder04

.gitignore

@@ -3,3 +3,4 @@ Debug
 obj
 *.exe
 *.dll
+*.lcpkg

README.md

@@ -26,23 +26,27 @@ apkg get https://github.com/alexcoder04/LeoConsole-external-scripts.git
 
 ## Usage
 
-It adds following commands to your console:
+This plugin adds following commands to your console:
 
-### `script <name>`
+### `<script-name> [args...]`
 
 Runs a script. It can be a Shell, Python, ... script or even a binary. Every
 executable in `$SAVEPATH/share/scripts` is considered a script. Following arguments
-are passed to the script (args are arguments you passed inside LeoConsole):
+are passed to the script (`args` are arguments you passed inside LeoConsole):
 
 ```text
-username savepath downloadpath args...
+username savepath downloadpath [args...]
 ```
 
+**Warning**: if one of the variables username, savepath or downloadpath has
+spaces, these will be replaced with dashes (`-`). This is also the case if the
+variable is empty or not defined.
+
 ### `scripts-list`
 
 Lists all scripts (executables) from `$SAVEPATH/share/scripts`.
 
-### `exec`
+### `exec <program> [args...]`
 
 Executes an arbitrary binary (from your `$PATH`).
 

exec.cs

@@ -47,7 +47,6 @@ private bool runProcess(string name, string args, string pwd) {
       }
       return true;
     }
-
   }
 }
 

external-scripts.lcpkg

@@ -4,19 +4,16 @@
 using ILeoConsole.Plugin;
 using ILeoConsole.Core;
 
-namespace LeoConsole_externalScripts
-{
-  public class ListScripts : ICommand
-  {
+namespace LeoConsole_externalScripts {
+  public class ListScripts : ICommand {
     public string Name { get { return "scripts-list"; } }
     public string Description { get { return "list installed scripts"; } }
     public Action CommandFunktion { get { return () => Command(); } }
     private string[] _InputProperties;
     public string[] InputProperties { get { return _InputProperties; } set { _InputProperties = value; } }
     public IData data = new ConsoleData();
 
-    public void Command()
-    {
+    public void Command() {
       try {
         foreach (string filename in Directory.GetFiles(Path.Join(data.SavePath, "share", "scripts"))) {
           Console.WriteLine(Path.GetFileName(filename));

list.cs

@@ -1,6 +1,7 @@
 {
-  "manifestVersion": 2.0,
+  "manifestVersion": 2.1,
   "packageName": "external-scripts",
+  "packageVersion": "1.0.0",
   "build": {
     "command": "dotnet",
     "args": ["build", "--nologo"],
@@ -11,7 +12,7 @@
   "project": {
     "maintainer": "alexcoder04",
     "email": "alexcoder04@protonmail.com",
-    "homepage": "https://github.com/alexcoder04/LeoConsole-apkg",
-    "bugTracker": "https://github.com/alexcoder04/LeoConsole-apkg/issues"
+    "homepage": "https://github.com/alexcoder04/LeoConsole-external-scripts",
+    "bugTracker": "https://github.com/alexcoder04/LeoConsole-external-scripts/issues"
   }
 }

manifest.apkg.json

@@ -30,14 +30,17 @@ public void PluginInit() {
       _data = new ConsoleData();
 
       _Commands = new List<ICommand>();
-      _Commands.Add(new Script());
       _Commands.Add(new ListScripts());
       _Commands.Add(new Exec());
     }
 
     public void PluginMain() {
       if (!Directory.Exists(Path.Join(_data.SavePath, "share", "scripts"))) {
-        Console.WriteLine("warning: scripts directory does not exist!");
+        Console.WriteLine("error: scripts folder does not exist!");
+        return;
+      }
+      foreach (string s in Directory.GetFiles(Path.Join(_data.SavePath, "share", "scripts"))) {
+        _Commands.Add(new Script(Path.GetFileName(s)));
       }
     }
 

plugin.cs

@@ -6,30 +6,41 @@
 
 namespace LeoConsole_externalScripts {
   public class Script : ICommand {
-    public string Name { get { return "script"; } }
-    public string Description { get { return "run script"; } }
+    public string Name { get; set; }
+    public string Description { get { return "external script"; } }
     public Action CommandFunktion { get { return () => Command(); } }
     private string[] _InputProperties;
     public string[] InputProperties { get { return _InputProperties; } set { _InputProperties = value; } }
     public IData data = new ConsoleData();
 
+    public Script(string name) {
+      Name = name;
+    }
+
     public void Command() {
-      if (_InputProperties.Length < 2){
-        Console.WriteLine("you need to provide the script name to run");
-        return;
+      string username = data.User.name.Replace(" ", "-");
+      if (username == "") {
+        username = "-";
+      }
+      string savepath = data.SavePath.Replace(" ", "-");
+      if (savepath == "") {
+        savepath = "-";
+      }
+      string dlpath = data.DownloadPath.Replace(" ", "-");
+      if (dlpath == "") {
+        dlpath = "-";
       }
-      Console.WriteLine("running " + _InputProperties[1] + "...");
       string args = "";
       for (int i = 1; i < _InputProperties.Length; i++) {
         args = args + " " + _InputProperties[i];
       }
 
       if (!runProcess(
-            Path.Join(data.SavePath, "share", "scripts", _InputProperties[1]),
-            $"{data.User.name} {data.SavePath} {data.DownloadPath} {args}",
-            data.SavePath)
-          ) {
-        Console.WriteLine("error running " + _InputProperties[1]);
+          Path.Join(data.SavePath, "share", "scripts", Name),
+          $"{username} {savepath} {dlpath} {args}",
+          data.SavePath
+        )) {
+        Console.WriteLine("error running " + Name);
       }
     }
 
@@ -52,7 +63,6 @@ private bool runProcess(string name, string args, string pwd) {
       }
       return true;
     }
-
   }
 }
 

script.cs

@@ -1,6 +1,6 @@
 #!/bin/sh
 
-echo "This is an example shell script"
+echo "This is an example shell script for LeoConsole"
 
 username="$1"; shift
 savepath="$1"; shift
@@ -9,12 +9,12 @@ dlpath="$1"; shift
 cat <<EOF
 
 ---
-
 Data I got from LeoConsole:
  - data.User.name: $username
  - data.SavePath: $savepath
  - data.DownloadPath: $dlpath
  - args: $@
+---
 
 EOF