Skip to content
This repository was archived by the owner on Sep 20, 2021. It is now read-only.

AndroidSupport ObservableRecyclerAdapter and ClickCallback #18

Open
VincentDW opened this issue Jan 16, 2018 · 0 comments
Open

AndroidSupport ObservableRecyclerAdapter and ClickCallback #18

VincentDW opened this issue Jan 16, 2018 · 0 comments

Comments

@VincentDW
Copy link

#Hello,

The ClickCallback is never use when a CreateViewHolderDelegate is given to ObservableRecyclerAdapter. With CellLayoutId, it's work fine.

Potential fix can be :
At line 508 of ObservableRecyclerAdapter file :

return CreateViewHolderDelegate(parent, viewType);

Replace with :

var createViewHolder = CreateViewHolderDelegate(parent, viewType);
var castedCreateViewHolder = createViewHolder as CachingViewHolder;
if (castedCreateViewHolder != null) 
{
         castedCreateViewHolder.ClickCallback = OnItemClick;
}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant