Skip to content

PgConnectOptions.options are not URL encoded #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rudolphfroger-ds opened this issue Aug 5, 2022 · 0 comments · May be fixed by #3800
Open

PgConnectOptions.options are not URL encoded #2027

rudolphfroger-ds opened this issue Aug 5, 2022 · 0 comments · May be fixed by #3800

Comments

@rudolphfroger-ds
Copy link

sqlx/sqlx-core/src/postgres/options/mod.rs

Line 431 in 728717f

write!(options_str, "-c {}={}", k, v).expect("failed to write an option to the string");

Test case:

let pg_connect_opts = PgConnectOptions::default()
    .database(db_name)
    .options([("default_transaction_isolation", "repeatable read")]);

Connecting with these options will given an error that "repeatable" is not a valid isolation level.

I think the solution is to URL encode options.
@abonander abonander linked a pull request Apr 14, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Escape PostgreSQL options V02460/sqlx
1 participant
@rudolphfroger-ds