feat(pool): add more info to impl Debug for PoolConnection

abonander · abonander · commit 13d1c018d1b2 · 2024-11-08T15:52:53.000-08:00
diff --git a/sqlx-core/src/pool/connection.rs b/sqlx-core/src/pool/connection.rs
@@ -48,8 +48,11 @@ const EXPECT_MSG: &str = "BUG: inner connection already taken!";
 
 impl<DB: Database> Debug for PoolConnection<DB> {
     fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
-        // TODO: Show the type name of the connection ?
-        f.debug_struct("PoolConnection").finish()
+        f
+            .debug_struct("PoolConnection")
+            .field("database", &DB::NAME)
+            .field("id", &self.live.as_ref().map(|live| live.id))
+            .finish()
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -48,8 +48,11 @@ const EXPECT_MSG: &str = "BUG: inner connection already taken!";`
`48`	`48`
`49`	`49`	`impl<DB: Database> Debug for PoolConnection<DB> {`
`50`	`50`	`fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {`
`51`		`- // TODO: Show the type name of the connection ?`
`52`		`- f.debug_struct("PoolConnection").finish()`
	`51`	`+ f`
	`52`	`+ .debug_struct("PoolConnection")`
	`53`	`+ .field("database", &DB::NAME)`
	`54`	`+ .field("id", &self.live.as_ref().map(\|live\| live.id))`
	`55`	`+ .finish()`
`53`	`56`	`}`
`54`	`57`	`}`
`55`	`58`