Enhance/912 reorder evaluations v2 types (#967)

* Reorder Evaluations 2.0 types

* wip

Author: neoxelox

apps/web/src/components/evaluations/human/index.tsx

@@ -0,0 +1,22 @@
+import {
+  EvaluationType,
+  HumanEvaluationMetric,
+  HumanEvaluationSpecification,
+} from '@latitude-data/constants'
+import { EvaluationMetricFrontendSpecification } from '../index'
+
+// prettier-ignore
+const METRICS: {
+  [M in HumanEvaluationMetric]: EvaluationMetricFrontendSpecification<EvaluationType.Human, M>
+} = {
+  [HumanEvaluationMetric.Binary]: undefined as any, // TODO: Implement
+  [HumanEvaluationMetric.Rating]: undefined as any, // TODO: Implement
+  [HumanEvaluationMetric.Comparison]: undefined as any, // TODO: Implement
+}
+
+const specification = HumanEvaluationSpecification
+export default {
+  ...specification,
+  ConfigurationForm: undefined as any, // TODO: Implement
+  metrics: METRICS,
+}

apps/web/src/components/evaluations/index.ts

@@ -0,0 +1,46 @@
+import {
+  EvaluationConfiguration,
+  EvaluationMetric,
+  EvaluationMetricSpecification,
+  EvaluationSpecification,
+  EvaluationType,
+} from '@latitude-data/constants'
+import { IconName } from '@latitude-data/web-ui'
+import React from 'react'
+import HumanEvaluationSpecification from './human'
+import LlmEvaluationSpecification from './llm'
+import RuleEvaluationSpecification from './rule'
+
+export type EvaluationMetricFrontendSpecification<
+  T extends EvaluationType = EvaluationType,
+  M extends EvaluationMetric<T> = EvaluationMetric<T>,
+> = EvaluationMetricSpecification<T, M> & {
+  icon: IconName
+  ConfigurationForm: (props: {
+    configuration: EvaluationConfiguration<T, M>
+    onChange: (configuration: EvaluationConfiguration<T, M>) => void
+  }) => React.ReactNode
+}
+
+export type EvaluationFrontendSpecification<
+  T extends EvaluationType = EvaluationType,
+> = Omit<EvaluationSpecification<T>, 'metrics'> & {
+  ConfigurationForm: <
+    M extends EvaluationMetric<T> = EvaluationMetric<T>,
+  >(props: {
+    metric: M
+    configuration: EvaluationConfiguration<T, M>
+    onChange: (configuration: EvaluationConfiguration<T>) => void
+  }) => React.ReactNode
+  metrics: {
+    [M in EvaluationMetric<T>]: EvaluationMetricFrontendSpecification<T, M>
+  }
+}
+
+export const EVALUATION_SPECIFICATIONS: {
+  [T in EvaluationType]: EvaluationFrontendSpecification<T>
+} = {
+  [EvaluationType.Rule]: RuleEvaluationSpecification,
+  [EvaluationType.Llm]: LlmEvaluationSpecification,
+  [EvaluationType.Human]: HumanEvaluationSpecification,
+}

apps/web/src/components/evaluations/llm/index.tsx

@@ -0,0 +1,22 @@
+import {
+  EvaluationType,
+  LlmEvaluationMetric,
+  LlmEvaluationSpecification,
+} from '@latitude-data/constants'
+import { EvaluationMetricFrontendSpecification } from '../index'
+
+// prettier-ignore
+const METRICS: {
+  [M in LlmEvaluationMetric]: EvaluationMetricFrontendSpecification<EvaluationType.Llm, M>
+} = {
+  [LlmEvaluationMetric.Binary]: undefined as any, // TODO: Implement
+  [LlmEvaluationMetric.Rating]: undefined as any, // TODO: Implement
+  [LlmEvaluationMetric.Comparison]: undefined as any, // TODO: Implement
+}
+
+const specification = LlmEvaluationSpecification
+export default {
+  ...specification,
+  ConfigurationForm: undefined as any, // TODO: Implement
+  metrics: METRICS,
+}

apps/web/src/components/evaluations/rule/ExactMatch.tsx

@@ -0,0 +1,24 @@
+import {
+  RuleEvaluationExactMatchConfiguration,
+  RuleEvaluationExactMatchSpecification,
+} from '@latitude-data/constants'
+import { IconName } from '@latitude-data/web-ui'
+
+const specification = RuleEvaluationExactMatchSpecification
+export default {
+  ...specification,
+  icon: 'equal' as IconName,
+  ConfigurationForm: ConfigurationForm,
+}
+
+function ConfigurationForm({
+  configuration,
+  onChange,
+}: {
+  configuration: RuleEvaluationExactMatchConfiguration
+  onChange: (configuration: RuleEvaluationExactMatchConfiguration) => void
+}) {
+  configuration // TODO: Implement
+  onChange // TODO: Implement
+  return <div>Exact Match</div>
+}

apps/web/src/components/evaluations/rule/RegularExpression.tsx

@@ -0,0 +1,26 @@
+import {
+  RuleEvaluationRegularExpressionConfiguration,
+  RuleEvaluationRegularExpressionSpecification,
+} from '@latitude-data/constants'
+import { IconName } from '@latitude-data/web-ui'
+
+const specification = RuleEvaluationRegularExpressionSpecification
+export default {
+  ...specification,
+  icon: 'regex' as IconName,
+  ConfigurationForm: ConfigurationForm,
+}
+
+function ConfigurationForm({
+  configuration,
+  onChange,
+}: {
+  configuration: RuleEvaluationRegularExpressionConfiguration
+  onChange: (
+    configuration: RuleEvaluationRegularExpressionConfiguration,
+  ) => void
+}) {
+  configuration // TODO: Implement
+  onChange // TODO: Implement
+  return <div>Regular Expression</div>
+}

apps/web/src/components/evaluations/rule/index.tsx

@@ -0,0 +1,51 @@
+import {
+  EvaluationType,
+  RuleEvaluationConfiguration,
+  RuleEvaluationMetric,
+  RuleEvaluationSpecification,
+} from '@latitude-data/constants'
+import { EvaluationMetricFrontendSpecification } from '../index'
+import RuleEvaluationExactMatchSpecification from './ExactMatch'
+import RuleEvaluationRegularExpressionSpecification from './RegularExpression'
+
+// prettier-ignore
+const METRICS: {
+  [M in RuleEvaluationMetric]: EvaluationMetricFrontendSpecification<EvaluationType.Rule, M>
+} = {
+  [RuleEvaluationMetric.ExactMatch]: RuleEvaluationExactMatchSpecification,
+  [RuleEvaluationMetric.RegularExpression]: RuleEvaluationRegularExpressionSpecification,
+  [RuleEvaluationMetric.LengthCount]:  undefined as any, // TODO: Implement
+  [RuleEvaluationMetric.LexicalOverlap]:  undefined as any, // TODO: Implement
+  [RuleEvaluationMetric.SemanticSimilarity]:  undefined as any, // TODO: Implement
+}
+
+const specification = RuleEvaluationSpecification
+export default {
+  ...specification,
+  ConfigurationForm: ConfigurationForm,
+  metrics: METRICS,
+}
+
+function ConfigurationForm<M extends RuleEvaluationMetric>({
+  metric,
+  configuration,
+  onChange,
+}: {
+  metric: M
+  configuration: RuleEvaluationConfiguration<M>
+  onChange: (configuration: RuleEvaluationConfiguration<M>) => void
+}) {
+  const metricSpecification = METRICS[metric]
+  if (!metricSpecification) return null
+
+  // TODO: Implement (probably dont pass the metric and make a selector component)
+  return (
+    <div>
+      <h1>Rule Evaluation</h1>
+      <metricSpecification.ConfigurationForm
+        configuration={configuration}
+        onChange={onChange}
+      />
+    </div>
+  )
+}

apps/web/src/lib/evaluations.ts

@@ -11,11 +11,8 @@ import { ROUTES } from '$/services/routes'
 import {
   Commit,
   DocumentVersion,
-  EvaluationConfiguration,
-  EvaluationMetric,
   EvaluationOptions,
   EvaluationSettings,
-  EvaluationType,
   EvaluationV2,
   Project,
 } from '@latitude-data/core/browser'
@@ -77,15 +74,11 @@ export default function useEvaluationsV2(
     },
   })
   const createEvaluation = useCallback(
-    async <
-      T extends EvaluationType,
-      M extends EvaluationMetric<T>,
-      C extends EvaluationConfiguration<M> = EvaluationConfiguration<M>,
-    >({
+    async ({
       settings,
       options,
     }: {
-      settings: EvaluationSettings<T, M, C>
+      settings: EvaluationSettings
       options?: Partial<EvaluationOptions>
     }) => {
       const [result, error] = await executeCreateEvaluationV2({
@@ -123,17 +116,13 @@ export default function useEvaluationsV2(
     },
   })
   const updateEvaluation = useCallback(
-    async <
-      T extends EvaluationType,
-      M extends EvaluationMetric<T>,
-      C extends EvaluationConfiguration<M> = EvaluationConfiguration<M>,
-    >({
+    async ({
       evaluationUuid,
       settings,
       options,
     }: {
       evaluationUuid: string
-      settings?: Partial<Omit<EvaluationSettings<T, M, C>, 'type' | 'metric'>>
+      settings?: Partial<Omit<EvaluationSettings, 'type' | 'metric'>>
       options?: Partial<EvaluationOptions>
     }) => {
       const [result, error] = await executeUpdateEvaluationV2({