Skip to content

Commit 8960d47

Browse files
committed
Fix bug showing cloud message always on settings > datasets
We were not checking if that message modal was open. This was part of a refactor where this modal was in an independent route. Now state lives in their parent component
1 parent 9223caa commit 8960d47

File tree

2 files changed

+19
-10
lines changed
  • apps/web/src/app/(private)/datasets/_components/RootHeader/GenerateDatasetModal

2 files changed

+19
-10
lines changed

apps/web/src/app/(private)/datasets/_components/RootHeader/GenerateDatasetModal/AutogenerateDatasetNotAvailableModal/index.tsx

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,21 @@
1-
'use client'
2-
31
import { ConfirmModal } from '@latitude-data/web-ui'
4-
import { useNavigate } from '$/hooks/useNavigate'
5-
import { ROUTES } from '$/services/routes'
62
import { CLOUD_MESSAGES } from '@latitude-data/core/browser'
73

8-
export function AutogenerateDatasetNotAvailableModal() {
9-
const navigate = useNavigate()
4+
export function AutogenerateDatasetNotAvailableModal({
5+
open,
6+
onOpenChange,
7+
}: {
8+
open: boolean
9+
10+
onOpenChange: (open: boolean) => void
11+
}) {
1012
return (
1113
<ConfirmModal
12-
open
13-
dismissible={false}
14+
dismissible
15+
open={open}
16+
onOpenChange={onOpenChange}
1417
title='Auto Generate dataset'
15-
onConfirm={() => navigate.push(ROUTES.datasets.root())}
18+
onConfirm={() => onOpenChange(false)}
1619
confirm={{
1720
label: 'Back to datasets',
1821
description: CLOUD_MESSAGES.autogenerateDatasets,

apps/web/src/app/(private)/datasets/_components/RootHeader/GenerateDatasetModal/index.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,13 @@ export function GenerateDatasetCloudModal({
2323
generateInput: GenerateInputProps
2424
canNotModify: boolean
2525
}) {
26-
if (!isCloud) return <AutogenerateDatasetNotAvailableModal />
26+
if (!isCloud)
27+
return (
28+
<AutogenerateDatasetNotAvailableModal
29+
open={open}
30+
onOpenChange={onOpenChange}
31+
/>
32+
)
2733

2834
if (canNotModify) {
2935
return (

0 commit comments

Comments
 (0)