Add more error logging

Author: neoxelox

packages/core/src/jobs/job-definitions/tracing/ingestSpansJob.ts

@@ -24,7 +24,10 @@ export const ingestSpansJob = async (job: Job<IngestSpansJobData>) => {
   try {
     const payload = await disk.get(key)
     data = JSON.parse(payload) as SpanIngestionData
-  } catch { return } // prettier-ignore
+  } catch (error) {
+    captureException(error as Error)
+    return
+  }
   const { spans } = data
 
   const result = await ingestSpans({ spans, apiKeyId, workspaceId })
@@ -37,5 +40,8 @@ export const ingestSpansJob = async (job: Job<IngestSpansJobData>) => {
 
   try {
     await disk.delete(key)
-  } catch { return } // prettier-ignore
+  } catch (error) {
+    captureException(error as Error)
+    return
+  }
 }

packages/core/src/jobs/job-definitions/tracing/processSegmentJob.ts

@@ -37,11 +37,17 @@ export const processSegmentJob = async (job: Job<ProcessSegmentJobData>) => {
     job.data
 
   const workspace = await unsafelyFindWorkspace(workspaceId)
-  if (!workspace) return
+  if (!workspace) {
+    captureException(new UnprocessableEntityError('Workspace not found'))
+    return
+  }
 
   const repository = new ApiKeysRepository(workspace.id)
   const finding = await repository.find(apiKeyId)
-  if (finding.error) return
+  if (finding.error) {
+    captureException(finding.error)
+    return
+  }
   const apiKey = finding.value
 
   const result = await processSegment({

packages/core/src/jobs/job-definitions/tracing/processSpanJob.ts

@@ -24,11 +24,17 @@ export const processSpanJob = async (job: Job<ProcessSpanJobData>) => {
   const { processingId, apiKeyId, workspaceId } = job.data
 
   const workspace = await unsafelyFindWorkspace(workspaceId)
-  if (!workspace) return
+  if (!workspace) {
+    captureException(new UnprocessableEntityError('Workspace not found'))
+    return
+  }
 
   const repository = new ApiKeysRepository(workspace.id)
   const finding = await repository.find(apiKeyId)
-  if (finding.error) return
+  if (finding.error) {
+    captureException(finding.error)
+    return
+  }
   const apiKey = finding.value
 
   const disk = diskFactory('private')
@@ -37,7 +43,10 @@ export const processSpanJob = async (job: Job<ProcessSpanJobData>) => {
   try {
     const payload = await disk.get(key)
     data = JSON.parse(payload) as SpanProcessingData
-  } catch { return } // prettier-ignore
+  } catch (error) {
+    captureException(error as Error)
+    return
+  }
   const { span, scope } = data
 
   const result = await processSpan({ span, scope, apiKey, workspace })
@@ -49,5 +58,8 @@ export const processSpanJob = async (job: Job<ProcessSpanJobData>) => {
 
   try {
     await disk.delete(key)
-  } catch { return } // prettier-ignore
+  } catch (error) {
+    captureException(error as Error)
+    return
+  }
 }

packages/core/src/services/tracing/spans/ingest.ts

@@ -26,12 +26,14 @@ import { hashContent as hash } from '../../../lib/hashContent'
 import { Result } from '../../../lib/Result'
 import { ApiKeysRepository } from '../../../repositories'
 import { internalBaggageSchema } from '../../../telemetry'
+import { captureException } from '../../../utils/workers/sentry'
 import {
   convertSpanAttributes,
   convertSpanStatus,
   extractSpanType,
 } from './process'
 
+// TODO(tracing): enhance this function
 export async function ingestSpans(
   {
     spans,
@@ -52,18 +54,27 @@ export async function ingestSpans(
     for (const { scope, spans } of scopeSpans) {
       for (const span of spans) {
         const converting = convertSpanAttributes(span.attributes || [])
-        if (converting.error) continue
+        if (converting.error) {
+          captureException(converting.error)
+          continue
+        }
         const attributes = converting.value
 
         const extracting = extractSpanType(attributes)
-        if (extracting.error) continue
+        if (extracting.error) {
+          captureException(extracting.error)
+          continue
+        }
         const type = extracting.value
         if (type === SpanType.Unknown) continue
 
         let internal
         if (!workspaceId) {
           const extracting = extractInternal(attributes)
-          if (extracting.error) continue
+          if (extracting.error) {
+            captureException(extracting.error)
+            continue
+          }
           internal = extracting.value
         }
 
@@ -73,7 +84,10 @@ export async function ingestSpans(
             { workspaceId: workspaceId ?? internal?.workspaceId },
             db,
           )
-          if (getting.error) continue
+          if (getting.error) {
+            captureException(getting.error)
+            continue
+          }
 
           workspace = getting.value
           workspaces[workspace.id] = workspace
@@ -85,14 +99,20 @@ export async function ingestSpans(
             { apiKeyId: apiKeyId ?? internal?.apiKeyId, workspace },
             db,
           )
-          if (getting.error) continue
+          if (getting.error) {
+            captureException(getting.error)
+            continue
+          }
 
           apiKey = getting.value
           apiKeys[apiKey.id] = apiKey
         }
 
         const enriching = enrichAttributes({ resource, scope, span })
-        if (enriching.error) continue
+        if (enriching.error) {
+          captureException(enriching.error)
+          continue
+        }
         span.attributes = enriching.value.filter(
           ({ key }) => key !== ATTR_LATITUDE_INTERNAL,
         )
@@ -101,7 +121,10 @@ export async function ingestSpans(
           { span, scope, resource, apiKey, workspace },
           disk,
         )
-        if (enqueuing.error) continue
+        if (enqueuing.error) {
+          captureException(enqueuing.error)
+          continue
+        }
       }
     }
   }