Fix agent tool maps recomputing too much (#962)

Author: andresgutgon

apps/web/src/hooks/useMetadata.ts

@@ -1,46 +1,36 @@
 'use client'
 
-import { useEffect, useRef, useState } from 'react'
+import { useEffect, useState } from 'react'
 
 import type { ConversationMetadata } from 'promptl-ai'
 import { useDebouncedCallback } from 'use-debounce'
 
 import type { ReadMetadataWorkerProps } from '../workers/readMetadata'
 
+const worker =
+  typeof window === 'undefined'
+    ? undefined
+    : new Worker(new URL('public/workers/readMetadata', import.meta.url))
+
 export function useMetadata({
   onMetadataProcessed,
 }: {
   onMetadataProcessed?: (metadata: ConversationMetadata) => void
 } = {}) {
   const [metadata, setMetadata] = useState<ConversationMetadata>()
-  const workerRef = useRef<Worker | null>(null)
 
   useEffect(() => {
-    if (typeof window === 'undefined') return
-
-    // Dynamic import for the worker
-    const createWorker = async () => {
-      const worker = new Worker(
-        new URL('public/workers/readMetadata', import.meta.url),
-      )
-      workerRef.current = worker
-
-      worker.onmessage = (event: { data: ConversationMetadata }) => {
-        setMetadata(event.data)
-        onMetadataProcessed?.(event.data)
-      }
-    }
-
-    createWorker()
+    if (typeof window === 'undefined' || !worker) return
 
-    return () => {
-      workerRef.current?.terminate()
+    worker.onmessage = (event: { data: ConversationMetadata }) => {
+      setMetadata(event.data)
+      onMetadataProcessed?.(event.data)
     }
   }, [onMetadataProcessed])
 
   const runReadMetadata = useDebouncedCallback(
     async (props: ReadMetadataWorkerProps) => {
-      workerRef.current?.postMessage(props)
+      worker?.postMessage(props)
     },
     500,
     { trailing: true },

apps/web/src/stores/agentToolsMap.ts

@@ -1,10 +1,20 @@
-import { HEAD_COMMIT } from '@latitude-data/core/browser'
+import { isEqual } from 'lodash-es'
+import { useEffect, useState } from 'react'
+import { type DocumentVersion, HEAD_COMMIT } from '@latitude-data/core/browser'
 import { SWRConfiguration } from 'swr'
 import useDocumentVersions from './documentVersions'
-import { useMemo } from 'react'
 import { getAgentToolName } from '@latitude-data/core/services/agents/helpers'
 import { AgentToolsMap } from '@latitude-data/constants'
 
+function buildAgentsToolMap(data: DocumentVersion[] = []) {
+  if (!data) return {}
+  return data.reduce((acc: AgentToolsMap, document) => {
+    if (document.documentType === 'agent') {
+      acc[getAgentToolName(document.path)] = document.path
+    }
+    return acc
+  }, {})
+}
 export function useAgentToolsMap(
   {
     commitUuid = HEAD_COMMIT,
@@ -17,14 +27,14 @@ export function useAgentToolsMap(
     opts,
   )
 
-  const agentToolsMap: AgentToolsMap = useMemo(() => {
-    if (!data) return {}
-    return data.reduce((acc: AgentToolsMap, document) => {
-      if (document.documentType === 'agent') {
-        acc[getAgentToolName(document.path)] = document.path
-      }
-      return acc
-    }, {})
+  const [agentToolsMap, setAgentToolsMap] = useState<AgentToolsMap>({})
+
+  useEffect(() => {
+    setAgentToolsMap((prev) => {
+      const newAgentToolMaps = buildAgentsToolMap(data)
+
+      return isEqual(prev, newAgentToolMaps) ? prev : newAgentToolMaps
+    })
   }, [data])
 
   return { data: agentToolsMap, isLoading, error }

apps/web/src/stores/documentVersions.ts

@@ -24,6 +24,7 @@ import { useRouter } from 'next/navigation'
 import useSWR, { SWRConfiguration } from 'swr'
 import { useServerAction } from 'zsa-react'
 
+const EMPTY_DATA = [] as DocumentVersion[]
 export default function useDocumentVersions(
   {
     commitUuid = HEAD_COMMIT,
@@ -62,7 +63,7 @@ export default function useDocumentVersions(
 
   const {
     mutate,
-    data = [],
+    data = EMPTY_DATA,
     isValidating,
     isLoading,
     error: swrError,