[5.x] Utilise Illuminate\Support\php_binary()

This would improves installation on Laravel Herd

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>

Author: crynobone

.github/workflows/tests.yml

@@ -70,7 +70,7 @@ jobs:
           composer config repositories.jetstream '{"type": "path", "url": "jetstream"}' --file composer.json
 
       - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           path: 'jetstream'
 

composer.json

@@ -16,8 +16,8 @@
     "require": {
         "php": "^8.2.0",
         "ext-json": "*",
-        "illuminate/console": "^11.0",
-        "illuminate/support": "^11.0",
+        "illuminate/console": "^11.25",
+        "illuminate/support": "^11.25",
         "laravel/fortify": "^1.20",
         "mobiledetect/mobiledetectlib": "^4.8",
         "symfony/console": "^7.0"

src/Console/InstallCommand.php

@@ -14,9 +14,9 @@
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Finder\Finder;
-use Symfony\Component\Process\PhpExecutableFinder;
 use Symfony\Component\Process\Process;
 
+use function Illuminate\Support\php_binary;
 use function Laravel\Prompts\confirm;
 use function Laravel\Prompts\multiselect;
 use function Laravel\Prompts\select;
@@ -397,7 +397,7 @@ protected function installInertiaStack()
 
         // Middleware...
         (new Filesystem)->ensureDirectoryExists(app_path('Http/Middleware'));
-        (new Process([$this->phpBinary(), 'artisan', 'inertia:middleware', 'HandleInertiaRequests', '--force'], base_path()))
+        (new Process([php_binary(), 'artisan', 'inertia:middleware', 'HandleInertiaRequests', '--force'], base_path()))
             ->setTimeout(null)
             ->run(function ($type, $output) {
                 $this->output->write($output);
@@ -656,7 +656,7 @@ protected function requireComposerPackages($packages)
         $composer = $this->option('composer');
 
         if ($composer !== 'global') {
-            $command = [$this->phpBinary(), $composer, 'require'];
+            $command = [php_binary(), $composer, 'require'];
         }
 
         $command = array_merge(
@@ -682,7 +682,7 @@ protected function removeComposerDevPackages($packages)
         $composer = $this->option('composer');
 
         if ($composer !== 'global') {
-            $command = [$this->phpBinary(), $composer, 'remove', '--dev'];
+            $command = [php_binary(), $composer, 'remove', '--dev'];
         }
 
         $command = array_merge(
@@ -708,7 +708,7 @@ protected function requireComposerDevPackages($packages)
         $composer = $this->option('composer');
 
         if ($composer !== 'global') {
-            $command = [$this->phpBinary(), $composer, 'require', '--dev'];
+            $command = [php_binary(), $composer, 'require', '--dev'];
         }
 
         $command = array_merge(
@@ -761,7 +761,7 @@ protected static function updateNodePackages(callable $callback, $dev = true)
     protected function runDatabaseMigrations()
     {
         if (confirm('New database migrations were added. Would you like to re-run your migrations?', true)) {
-            (new Process([$this->phpBinary(), 'artisan', 'migrate:fresh', '--force'], base_path()))
+            (new Process([php_binary(), 'artisan', 'migrate:fresh', '--force'], base_path()))
                 ->setTimeout(null)
                 ->run(function ($type, $output) {
                     $this->output->write($output);
@@ -795,16 +795,6 @@ protected function removeDarkClasses(Finder $finder)
         }
     }
 
-    /**
-     * Get the path to the appropriate PHP binary.
-     *
-     * @return string
-     */
-    protected function phpBinary()
-    {
-        return (new PhpExecutableFinder())->find(false) ?: 'php';
-    }
-
     /**
      * Run the given commands.
      *