Usage of "greeting" and "salutation" on SimpleMessage is grammatically incorrect

[shengslogar]

I'll be the first to admit this is overly pedantic, and likely not worth serious consideration for the sake of backwards-compatibility, but thought this would be interesting to note.

Laravel uses "greeting" to open a message, and "salutation" to close it. However, both of these terms are largely synonymous. Merriam Webster defines "greeting" as "an expression of good wishes" and "salutation" as "the word or phrase of greeting... that conventionally comes immediately before the body of a letter".

If a PR were created for this, I would keep "greeting" for opening the message (it's less formal and more widely understood), and choose something like "closing" to replace "salutation".

Excuse me while I go do something more productive with my life. 😆

Related code:

framework/src/Illuminate/Notifications/Messages/SimpleMessage.php

Lines 24 to 36 in fc8f819

	/**
	* The notification's greeting.
	*
	* @var string
	*/
	public $greeting;
	/**
	* The notification's salutation.
	*
	* @var string
	*/
	public $salutation;

framework/src/Illuminate/Notifications/resources/views/email.blade.php

Lines 2 to 11 in fc8f819

	{{-- Greeting --}}
	@if (! empty($greeting))
	# {{ $greeting }}
	@else
	@if ($level === 'error')
	# @lang('Whoops!')
	@else
	# @lang('Hello!')
	@endif
	@endif

framework/src/Illuminate/Notifications/resources/views/email.blade.php

Lines 38 to 44 in fc8f819

	{{-- Salutation --}}
	@if (! empty($salutation))
	{{ $salutation }}
	@else
	@lang('Regards'),<br>
	{{ config('app.name') }}
	@endif

[Healyhatman]

I would, at the very least, comment the function so it actually says that it's a closing message. "Sets the salutation" tells me only as much as the function name does.