A simpler way to query relationship columns

[mortenscheel]

EDIT: Nevermind, whereRelation() basically does the same thing.

Hi all.

Wouldn't it be convenient if we could write a query like

User::whereHas('team.customer', fn($query) => $query->where('id', 1))->get();

like this instead?

User::whereHasRelatedAttribute('team.customer.id', 1)->get();

I mean, arrow functions have definitely made callbacks easier and cleaner, but for a simple and common use case such as the example, I think a "shortcut" is justified.

Here are a few proof of concept macros for the Eloquent builder:

Builder::macro('whereHasRelatedAttribute', function(string $attributePath, $operator = null, $value = null) {
    $attribute = Str::afterLast($attributePath, '.');
    $relation = Str::beforeLast($attributePath, '.');
    $callback = function($query) use ($attribute, $operator, $value) {
        $query->where($attribute, $operator, $value);
    };
    
    return $this->has(relation: $relation, callback: $callback);
});

Builder::macro('orWhereHasRelatedAttribute', function(string $attributePath, $operator = null, $value = null) {
    $attribute = Str::afterLast($attributePath, '.');
    $relation = Str::beforeLast($attributePath, '.');
    $callback = function($query) use ($attribute, $operator, $value) {
        $query->where($attribute, $operator, $value);
    };

    return $this->has(relation: $relation, boolean: 'or', callback: $callback);
});

Builder::macro('withWhereHasRelatedAttribute', function(string $attributePath, $operator = null, $value = null) {
    $attribute = Str::afterLast($attributePath, '.');
    $relation = Str::beforeLast($attributePath, '.');
    $callback = function($query) use ($attribute, $operator, $value) {
        $query->where($attribute, $operator, $value);
    };

    return $this->with([$relation => $callback])->whereHas($relation, $callback);
});

Are there any issues with this approach? Or am I alone in thinking this would be a super convenient feature?