Octane: usage of environment variables

[xorinzor]

Hey all,

I'm starting to use octane in my project and was wondering if it's on purpose that there seems to be little to no use of environment variables to configure the octane server.

Every config in laravel makes extensive use of environment variables (which is perfect for Saas applications!) but the octane configuration seems very limited. Not only that, but having had a look at the artisan commands that octane provides it only seems to accept commandline arguments to specify items such as host, port, workers, etc.

Swoole on the other hand already has environment variables such as SWOOLE_HTTP_HOST and SWOOLE_HTTP_PORT and will use these if you run php artisan swoole:http start. Going back to octane's StartSwooleCommand it seems that it not only doesn't use these environment variables, but also actively clears them by calling forgetEnvironmentVariables().

This all seems very odd to me. Wouldn't it be much better to have in octane's StartCommand::startSwooleServer() something alike the following:

return $this->call('octane:swoole', [
            '--host' => env('OCTANE_HOST', $this->option('host')),
            '--port' => env('OCTANE_PORT', $this->option('port')),
           ... snipped-code ...
        ]);

instead of the current:

return $this->call('octane:swoole', [
            '--host' => $this->option('host'),
            '--port' => $this->option('port'),
            ... snipped-code ...
        ]);

And do something similar for Roadrunner as well.
This would not break any existing code, but allow the usage of environment variables to configure octane.