Enhance Email and Image Dimensions Validation Tests (#54897)

* Added new test cases for special values, constraint order, value overriding in `ValidationDimensionsRuleTest`.

* Add more email validation cases to the testBasic method.

Author: alikhosravidev

tests/Validation/ValidationDimensionsRuleTest.php

@@ -53,6 +53,42 @@ public function testItCorrectlyFormatsAStringVersionOfTheRule()
         $this->assertSame('dimensions:min_ratio=0.5,max_ratio=0.33333333333333', (string) $rule);
     }
 
+    public function testItCorrectlyFormatsWithSpecialValues()
+    {
+        $rule = new Dimensions();
+
+        $this->assertSame('dimensions:', (string) $rule);
+
+        $rule = Rule::dimensions()->width(-100)->height(-200);
+
+        $this->assertSame('dimensions:width=-100,height=-200', (string) $rule);
+
+        $rule = Rule::dimensions()->width('300')->height('400');
+
+        $this->assertSame('dimensions:width=300,height=400', (string) $rule);
+    }
+
+    public function testDimensionsRuleMaintainsCorrectOrder()
+    {
+        $rule = Rule::dimensions()->minWidth(100)->width(200)->maxWidth(300);
+
+        $this->assertSame('dimensions:min_width=100,width=200,max_width=300', (string) $rule);
+    }
+
+    public function testOverridingValues()
+    {
+        $rule = Rule::dimensions()->width(100)->width(500);
+
+        $this->assertSame('dimensions:width=500', (string) $rule);
+    }
+
+    public function testRatioBetweenOverridesMinAndMaxRatio()
+    {
+        $rule = Rule::dimensions()->minRatio(0.5)->maxRatio(2.0)->ratioBetween(1, 1.5);
+
+        $this->assertSame('dimensions:min_ratio=1,max_ratio=1.5', (string) $rule);
+    }
+
     public function testGeneratesTheCorrectValidationMessages()
     {
         $rule = Rule::dimensions()

tests/Validation/ValidationEmailRuleTest.php

@@ -33,6 +33,18 @@ public function testBasic()
             ['The '.self::ATTRIBUTE_REPLACED.' must be a valid email address.']
         );
 
+        $this->fails(
+            Email::default(),
+            12345,
+            [Email::class]
+        );
+
+        $this->fails(
+            Rule::email(),
+            12345,
+            [Email::class]
+        );
+
         $this->passes(
             Email::default(),
             'taylor@laravel.com'
@@ -43,6 +55,16 @@ public function testBasic()
             'taylor@laravel.com'
         );
 
+        $this->passes(
+            Rule::email(),
+            ['taylor@laravel.com'],
+        );
+
+        $this->passes(
+            Email::default(),
+            ['taylor@laravel.com'],
+        );
+
         $this->passes(Email::default(), null);
 
         $this->passes(Rule::email(), null);