[12.x] Feature: Array partition (#54859)

* add array partition method

* allow traversable in array partition

* use array partition in collection partition

* remove unneccesary import

* use iterable instead of array|Traversable

Author: liamduckett

src/Illuminate/Collections/Arr.php

@@ -942,6 +942,32 @@ public static function reject($array, callable $callback)
         return static::where($array, fn ($value, $key) => ! $callback($value, $key));
     }
 
+    /**
+     * Partition the array into two arrays using the given callback.
+     *
+     * @template TKey of array-key
+     * @template TValue of mixed
+     *
+     * @param  iterable<TKey, TValue>  $array
+     * @param  callable  $callback
+     * @return array<int<0, 1>, array<TKey, TValue>>
+     */
+    public static function partition($array, callable $callback)
+    {
+        $passed = [];
+        $failed = [];
+
+        foreach ($array as $key => $item) {
+            if ($callback($item, $key)) {
+                $passed[$key] = $item;
+            } else {
+                $failed[$key] = $item;
+            }
+        }
+
+        return [$passed, $failed];
+    }
+
     /**
      * Filter items where the value is not null.
      *

src/Illuminate/Collections/Traits/EnumeratesValues.php

@@ -504,20 +504,11 @@ public function forPage($page, $perPage)
      */
     public function partition($key, $operator = null, $value = null)
     {
-        $passed = [];
-        $failed = [];
-
         $callback = func_num_args() === 1
                 ? $this->valueRetriever($key)
                 : $this->operatorForWhere(...func_get_args());
 
-        foreach ($this as $key => $item) {
-            if ($callback($item, $key)) {
-                $passed[$key] = $item;
-            } else {
-                $failed[$key] = $item;
-            }
-        }
+        [$passed, $failed] = Arr::partition($this->getIterator(), $callback);
 
         return new static([new static($passed), new static($failed)]);
     }