-
Notifications
You must be signed in to change notification settings - Fork 17.5k
Open
Labels
good first issueGood first issue for newcomersGood first issue for newcomers
Description
Self Checks
- I have read the Contributing Guide and Language Policy.
- This is only for refactoring, if you would like to ask a question, please head to Discussions.
- I have searched for existing issues search for existing issues, including closed ones.
- I confirm that I am using English to submit this report, otherwise it will be closed.
- 【中文用户 & Non English User】请使用英语提交,否则会被关闭 :)
- Please do not modify this template :) and fill in all the required fields.
Description
after #24115
from
with Session(...) as session:
...
session.commit()
to
with sessionmaker(...).begin() as session:
...
Motivation
we can now construct a Session() and include begin()/commit()/rollback() at once
Additional Context
https://docs.sqlalchemy.org/en/20/orm/session_basics.html#framing-out-a-begin-commit-rollback-block
also
https://docs.sqlalchemy.org/en/20/orm/session_basics.html#using-a-sessionmaker
example #24246
dosubot and QuantumGhost
Metadata
Metadata
Assignees
Labels
good first issueGood first issue for newcomersGood first issue for newcomers