Merge pull request #186 from langgenius/fix/infinity-environment-setup

fix( full-duplex lifecycle): avoid infinity setup loop

Author: Yeuoly

internal/core/plugin_manager/install_to_local.go

@@ -3,6 +3,7 @@ package plugin_manager
 import (
 	"time"
 
+	"github.com/langgenius/dify-plugin-daemon/internal/utils/log"
 	"github.com/langgenius/dify-plugin-daemon/internal/utils/routine"
 	"github.com/langgenius/dify-plugin-daemon/internal/utils/stream"
 	"github.com/langgenius/dify-plugin-daemon/pkg/entities/plugin_entities"
@@ -61,7 +62,14 @@ func (p *PluginManager) InstallToLocal(
 				return
 			case err := <-errChan:
 				if err != nil {
-					// if error occurs, stop the plugin
+					// if error occurs, delete the plugin from local and stop the plugin
+					identity, err := runtime.Identity()
+					if err != nil {
+						log.Error("get plugin identity failed: %s", err.Error())
+					}
+					if err := p.installedBucket.Delete(identity); err != nil {
+						log.Error("delete plugin from local failed: %s", err.Error())
+					}
 					response.Write(PluginInstallResponse{
 						Event: PluginInstallEventError,
 						Data:  err.Error(),

internal/core/plugin_manager/runtime_lifetime.go

@@ -13,6 +13,14 @@ func (p *PluginManager) AddPluginRegisterHandler(handler func(r plugin_entities.
 	p.pluginRegisters = append(p.pluginRegisters, handler)
 }
 
+// fullDuplexLifecycle takes the responsibility of full-duplex lifecycle of a plugin
+// it will block the thread until the plugin is stopped so it's important to call it in a new goroutine
+//  1. try to init environment until succeed or plugin has failed too many times
+//  2. launchedChan and errChan are used to synchronize the plugin launch process
+//     only if received non-nil message from errChan, it's considered the setup process has failed
+//  3. after exit, environment will be cleaned up
+//
+// NOTE: the size of launchedChan and errChan should always be 0 to keep the sync mechanism working
 func (p *PluginManager) fullDuplexLifecycle(
 	r plugin_entities.PluginFullDuplexLifetime,
 	launchedChan chan bool,
@@ -65,6 +73,8 @@ func (p *PluginManager) fullDuplexLifecycle(
 					close(launchedChan)
 				}
 			})
+
+			return
 		}
 
 		log.Info("init environment for plugin %s", configuration.Identity())