Chroma constructor parameter 'embedding_function' suggestion

[KylePancamo]

I haven't checked out other vectorstores, but within the Chroma vectorstore the member variable 'embedding_function' seems to be misleading. When reading the code, it appears that the parameter takes in a concrete Embeddings class and later uses the function if I am to understand it correctly.

langchain/libs/langchain/langchain/vectorstores/chroma.py

Line 72 in a5a4c53

embedding_function: Optional[Embeddings] = None,

langchain/libs/langchain/langchain/vectorstores/chroma.py

Line 125 in a5a4c53

self._embedding_function = embedding_function

langchain/libs/langchain/langchain/vectorstores/chroma.py

Line 187 in a5a4c53

embeddings = self._embedding_function.embed_documents(texts)

From my understanding and looking at the source code you need the entire class for api specifics, yet name implies you pass a function and not an instance of a class. A suggestion is to rename the parameter to embeddings unless there's a specific reason for the name.