You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I searched existing ideas and did not find a similar one
I added a very descriptive title
I've clearly described the feature request and motivation for it
Feature request
Currently the init file in any integration type is imported from the langchain-community package
for example, vector stores are all imported from this package
Many of those integrations are deprecated, e.g. Milvus vector store should be imported from langchain-milvus, at this point all official documentation are pointing to the newer package
At this moment, when any vector store is imported with: from langchain.vectorstores import Milvus
The deprecated module is imported by default, this should be fixed to import from the correct path.
Motivation
Importing from the wrong path imports outdated and unmaintained code which can cause a lot of compatibility and security issues.
As far as I understand, in order to fix, paths should be changed in the __init__ file and for each integration path, e.g. for the Milvus vectorstore file milvus.py
The code:
if TYPE_CHECKING:
from langchain_community.vectorstores import Milvus
Should be changed to:
if TYPE_CHECKING:
from langchain_milvus import Milvus
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Checked
Feature request
Currently the init file in any integration type is imported from the langchain-community package
for example, vector stores are all imported from this package
Many of those integrations are deprecated, e.g. Milvus vector store should be imported from langchain-milvus, at this point all official documentation are pointing to the newer package
At this moment, when any vector store is imported with:
from langchain.vectorstores import Milvus
The deprecated module is imported by default, this should be fixed to import from the correct path.
Motivation
Importing from the wrong path imports outdated and unmaintained code which can cause a lot of compatibility and security issues.
As far as I understand, in order to fix, paths should be changed in the
__init__
file and for each integration path, e.g. for the Milvus vectorstore filemilvus.py
The code:
Should be changed to:
Proposal (If applicable)
No response
Beta Was this translation helpful? Give feedback.
All reactions