You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I searched existing ideas and did not find a similar one
I added a very descriptive title
I've clearly described the feature request and motivation for it
Feature request
I think that:
If the delete method of a VectorStore is not implemented, it should throw an exception rather than returning None
The method delete for InMemoryVectorStore should be implemented
Motivation
I was running my RAG on old documents because I didn't realize the method was unimplemented. The user can catch the exception anyway. I think the standard is to throw an exception in these cases
I think implementing the method for the in-memory vector store should not be too difficult
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Checked
Feature request
I think that:
delete
method of a VectorStore is not implemented, it should throw an exception rather than returning Nonedelete
for InMemoryVectorStore should be implementedMotivation
Proposal (If applicable)
No response
Beta Was this translation helpful? Give feedback.
All reactions