Embedding doesn't work as expected using from_documents

[friweber]

I want to use instructor embedding in the from_documents function. I do this as follows

ef = embedding_functions.InstructorEmbeddingFunction()
db = Chroma.from_documents(docs, persist_directory="db", embedding = ef)

I get the error message 'InstructorEmbeddingFunction' object has no attribute 'embed_documents'.

Thanks for all helpful answers in advance!

[vr140]

It appears InstructorEmbeddingFunction is of the wrong type. It looks like it's from the Chroma library whereas the embedding argument in from_documents requires something of type Embeddings found in the langchain library: https://python.langchain.com/en/latest/reference/modules/embeddings.html.

One solution is to make a new Embeddings class that wraps the Chroma internal InstructorEmbeddingFunction.