You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I searched existing ideas and did not find a similar one
I added a very descriptive title
I've clearly described the feature request and motivation for it
Feature request
Slight alteration of source code to be able to use rephrase_question=False to skip question condensor/rephraser invocation and just pass input question to retriever.
Motivation
rephrase_question exisiting in current base class but not skipping the question rephraser invocation destroy the purpose of the parameter it self. Avoiding the invocation can also save cost/compute by skipping the invocation
Proposal (If applicable)
For lines 144 & 196 of libs/langchain/langchain/chains/conversational_retrieval/base.py
if chat_history_str and rephrase_question:
callbacks = _run_manager.get_child()
new_question = self.question_generator.run(
question=question, chat_history=chat_history_str, callbacks=callbacks
)
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Checked
Feature request
Slight alteration of source code to be able to use rephrase_question=False to skip question condensor/rephraser invocation and just pass input question to retriever.
Motivation
rephrase_question exisiting in current base class but not skipping the question rephraser invocation destroy the purpose of the parameter it self. Avoiding the invocation can also save cost/compute by skipping the invocation
Proposal (If applicable)
For lines 144 & 196 of libs/langchain/langchain/chains/conversational_retrieval/base.py
Beta Was this translation helpful? Give feedback.
All reactions