From d3dd5a66cbc8238cf33df0a3cd2f21c6cfc76077 Mon Sep 17 00:00:00 2001 From: romain-priour-lc Date: Mon, 29 Sep 2025 20:44:19 -0700 Subject: [PATCH 1/3] add storage engine validation --- charts/langsmith/templates/NOTES.txt | 1 + charts/langsmith/templates/_helpers.tpl | 13 +++++++++++++ 2 files changed, 14 insertions(+) diff --git a/charts/langsmith/templates/NOTES.txt b/charts/langsmith/templates/NOTES.txt index fb6f417f..a7bfe3eb 100644 --- a/charts/langsmith/templates/NOTES.txt +++ b/charts/langsmith/templates/NOTES.txt @@ -1,4 +1,5 @@ {{- include "langsmith.validateTracing" . -}} +{{- include "langsmith.validateBlobStorage" . -}} Thank you for installing LangSmith! This is the LangSmith application helm chart. All pods should be running! You can access the LangSmith UI by running the following command: diff --git a/charts/langsmith/templates/_helpers.tpl b/charts/langsmith/templates/_helpers.tpl index 57e01f00..6e88daed 100644 --- a/charts/langsmith/templates/_helpers.tpl +++ b/charts/langsmith/templates/_helpers.tpl @@ -519,6 +519,19 @@ Validate tracing configuration {{- end -}} {{- end -}} +{{/* +Validate blob storage configuration + */}} +{{- define "langsmith.validateBlobStorage" -}} +{{- if and .Values.config.blobStorage.enabled (not .Values.config.blobStorage.engine) -}} +{{- fail "When blob storage is enabled (config.blobStorage.enabled=true), config.blobStorage.engine must be one of [S3, Azure]" -}} +{{- end -}} +{{- if and .Values.config.blobStorage.enabled (not (or (eq .Values.config.blobStorage.engine "S3") (eq .Values.config.blobStorage.engine "Azure"))) -}} +{{- fail "When blob storage is enabled (config.blobStorage.enabled=true), config.blobStorage.engine must be one of [S3, Azure]" -}} +{{- end -}} +{{- end -}} + + {{- define "langsmith.tlsVolumeMounts" -}} {{- if and .Values.config.customCa.secretName .Values.config.customCa.secretKey -}} - name: langsmith-custom-ca From a4950af599aeccf8168cadf4b70ecc3bc2957361 Mon Sep 17 00:00:00 2001 From: romain-priour-lc Date: Tue, 30 Sep 2025 11:12:23 -0700 Subject: [PATCH 2/3] support lowercase s3 as well --- charts/langsmith/templates/_helpers.tpl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/charts/langsmith/templates/_helpers.tpl b/charts/langsmith/templates/_helpers.tpl index 6e88daed..5ff2de3a 100644 --- a/charts/langsmith/templates/_helpers.tpl +++ b/charts/langsmith/templates/_helpers.tpl @@ -280,7 +280,7 @@ Template containing common environment variables that are used by several servic value: {{ .Values.config.blobStorage.engine | quote }} - name: MIN_BLOB_STORAGE_SIZE_KB value: {{ ternary 0 .Values.config.blobStorage.minBlobStorageSizeKb .Values.clickhouse.external.hybrid | quote }} -{{- if eq .Values.config.blobStorage.engine "S3" }} +{{- if (or (eq .Values.config.blobStorage.engine "S3") (eq .Values.config.blobStorage.engine "s3")) }} - name: S3_BUCKET_NAME value: {{ .Values.config.blobStorage.bucketName | quote }} - name: S3_RUN_MANIFEST_BUCKET_NAME @@ -524,10 +524,10 @@ Validate blob storage configuration */}} {{- define "langsmith.validateBlobStorage" -}} {{- if and .Values.config.blobStorage.enabled (not .Values.config.blobStorage.engine) -}} -{{- fail "When blob storage is enabled (config.blobStorage.enabled=true), config.blobStorage.engine must be one of [S3, Azure]" -}} +{{- fail "When blob storage is enabled (config.blobStorage.enabled=true), config.blobStorage.engine must be one of [S3, s3, Azure]" -}} {{- end -}} -{{- if and .Values.config.blobStorage.enabled (not (or (eq .Values.config.blobStorage.engine "S3") (eq .Values.config.blobStorage.engine "Azure"))) -}} -{{- fail "When blob storage is enabled (config.blobStorage.enabled=true), config.blobStorage.engine must be one of [S3, Azure]" -}} +{{- if and .Values.config.blobStorage.enabled (not (or (eq .Values.config.blobStorage.engine "S3") (eq .Values.config.blobStorage.engine "s3") (eq .Values.config.blobStorage.engine "Azure"))) -}} +{{- fail "When blob storage is enabled (config.blobStorage.enabled=true), config.blobStorage.engine must be one of [S3, s3, Azure]" -}} {{- end -}} {{- end -}} From c72d899fec042caaf8dd777f2e85a0f547ba1591 Mon Sep 17 00:00:00 2001 From: romain-priour-lc Date: Tue, 30 Sep 2025 19:25:39 -0700 Subject: [PATCH 3/3] added lowercase azure as well --- charts/langsmith/templates/_helpers.tpl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/charts/langsmith/templates/_helpers.tpl b/charts/langsmith/templates/_helpers.tpl index 5ff2de3a..e503baf6 100644 --- a/charts/langsmith/templates/_helpers.tpl +++ b/charts/langsmith/templates/_helpers.tpl @@ -300,7 +300,7 @@ Template containing common environment variables that are used by several servic key: blob_storage_access_key_secret optional: true {{- end }} -{{- if eq .Values.config.blobStorage.engine "Azure" }} +{{- if (or (eq .Values.config.blobStorage.engine "Azure") (eq .Values.config.blobStorage.engine "azure")) }} - name: AZURE_STORAGE_ACCOUNT_NAME value: {{ .Values.config.blobStorage.azureStorageAccountName | quote }} - name: AZURE_STORAGE_CONTAINER_NAME @@ -524,10 +524,10 @@ Validate blob storage configuration */}} {{- define "langsmith.validateBlobStorage" -}} {{- if and .Values.config.blobStorage.enabled (not .Values.config.blobStorage.engine) -}} -{{- fail "When blob storage is enabled (config.blobStorage.enabled=true), config.blobStorage.engine must be one of [S3, s3, Azure]" -}} +{{- fail "When blob storage is enabled (config.blobStorage.enabled=true), config.blobStorage.engine must be one of [S3, Azure]" -}} {{- end -}} -{{- if and .Values.config.blobStorage.enabled (not (or (eq .Values.config.blobStorage.engine "S3") (eq .Values.config.blobStorage.engine "s3") (eq .Values.config.blobStorage.engine "Azure"))) -}} -{{- fail "When blob storage is enabled (config.blobStorage.enabled=true), config.blobStorage.engine must be one of [S3, s3, Azure]" -}} +{{- if and .Values.config.blobStorage.enabled (not (or (eq .Values.config.blobStorage.engine "S3") (eq .Values.config.blobStorage.engine "s3") (eq .Values.config.blobStorage.engine "Azure") (eq .Values.config.blobStorage.engine "azure"))) -}} +{{- fail "When blob storage is enabled (config.blobStorage.enabled=true), config.blobStorage.engine must be one of [S3, Azure]" -}} {{- end -}} {{- end -}}