use mailFrom to set sendmail services

Author: AaronFeledy

builders/mailpit.js

@@ -19,7 +19,7 @@ const setConfigOptions = require('../utils/setConfigOptions');
  * @typedef {object} MailpitConfig
  * @property {string} version - Version of Mailpit to use
  * @property {string[]} supported - Supported versions of Mailpit
- * @property {string[]} sendFrom - Services to configure for sending mail to Mailpit
+ * @property {string[]} mailFrom - Services to configure for sending mail to Mailpit
  * @property {number} maxMessages - Maximum number of messages to store before truncating
  * @property {number} port - SMTP port to use for sending mail to Mailpit
  * @property {boolean} ssl - Whether to use SSL for the Mailpit UI
@@ -49,7 +49,7 @@ module.exports = {
   config: {
     version: '1.20',
     supported: ['1.20'],
-    sendFrom: [],
+    mailFrom: [],
     maxMessages: 500,
     port: 1025,
     confSrc: path.resolve(__dirname, '..', 'config'),
@@ -108,7 +108,7 @@ module.exports = {
         options.meUser = 'root';
 
         // Add senders information to options
-        options.info = {sendFrom: options.sendFrom};
+        options.info = {mailFrom: options.mailFrom};
 
         // Set configuration options for the Lando service
         setConfigOptions({
@@ -127,7 +127,7 @@ module.exports = {
         addBuildStep(buildSteps, options._app, options.name, 'build_as_root_internal');
 
         // Configure other services to use Mailpit
-        options.sendFrom.forEach(service => {
+        options.mailFrom.forEach(service => {
           options.sources.push({
             services: _.set({}, service, {
               environment: {

examples/mailpit/.lando.yml

@@ -4,7 +4,7 @@ services:
     type: php:8.2
   smtpserver:
     type: mailpit
-    sendFrom:
+    mailFrom:
       - phpserver
 
 # This is important because it lets lando know to test against the plugin in this repo

test/mailpit.spec.js

@@ -39,7 +39,7 @@ describe('Mailpit Builder', function() {
     mockOptions = {
       data: 'data_smtpserver',
       meUser: undefined,
-      sendFrom: ['phpserver'],
+      mailFrom: ['phpserver'],
       info: undefined,
       name: 'smtpserver',
       port: undefined,
@@ -57,7 +57,7 @@ describe('Mailpit Builder', function() {
     expect(instance.id).to.equal('smtpserver');
     expect(instance.options.name).to.equal('smtpserver');
     expect(instance.options.data).to.equal('data_smtpserver');
-    expect(instance.options.sendFrom).to.deep.equal(['phpserver']);
+    expect(instance.options.mailFrom).to.deep.equal(['phpserver']);
   });
 
   it('should use default values when not provided in options', () => {
@@ -108,11 +108,11 @@ describe('Mailpit Builder', function() {
     expect(mailpitService.volumes).to.deep.equal(['data_smtpserver:/data']);
   });
 
-  it('should configure other services when sendFrom is provided', () => {
+  it('should configure other services when mailFrom is provided', () => {
     const LandoMailpitService = mailpitBuilder.builder(mockParent, mailpitBuilder.config);
     const instance = new LandoMailpitService('smtpserver', mockOptions);
 
-    // Check that the sendFrom services are configured in options.sources
+    // Check that the mailFrom services are configured in options.sources
     const phpserverSource = instance.options.sources.find(source =>
       source.services && source.services.phpserver,
     );