attempt the whole flow part 2

Author: pirog

.github/workflows/deploy-artifacts.yml

@@ -1,4 +1,4 @@
-name: Release Binary
+name: Deploy GitHub Artifacts
 
 on:
   workflow_call:
@@ -20,42 +20,26 @@ on:
         type: string
 
 jobs:
-  release-binary:
+  deploy-artifacts:
     runs-on: ubuntu-24.04
     env:
       TERM: xterm
     steps:
       - name: Create and enter path
         run: |
-          mkdir -p /tmp/deploy-s3/${{ github.sha }}
-          cd /tmp/${{ github.sha }}
-      - name: Download binaries
+          mkdir -p /tmp/deploy-artifacts/${{ github.sha }}
+          cd /tmp/deploy-artifacts/${{ github.sha }}
+      - name: Download artifacts
         id: download-artifacts
         uses: actions/download-artifact@v4
         with:
           name: ${{ inputs.download-name }}
           merge-multiple: true
-          path: /tmp/deploy-s3/${{ github.sha }}
+          path: /tmp/deploy-artifacts/${{ github.sha }}
           pattern: ${{ inputs.download-pattern }}
-      - name: Configure S3 Credentials
-        uses: aws-actions/configure-aws-credentials@v4
-        with:
-          aws-access-key-id: ${{ secrets.S3_ACCESS_KEY_ID }}
-          aws-secret-access-key: ${{ secrets.S3_SECRET_ACCESS_KEY }}
-          aws-region: us-east-1
-      - name: Upload dev releases to S3
-        shell: bash
-        run: |
-          aws s3 sync /tmp/deploy-s3/${{ github.sha }} s3://files.lando.dev
-          aws s3 sync /tmp/deploy-s3/${{ github.sha }} s3://files.lando.dev/cli
-          aws s3 sync /tmp/deploy-s3/${{ github.sha }} s3://files.lando.dev/core
-
-
-      - name: Upload signed binaries
+      - name: Upload artifacts
         uses: actions/upload-artifact@v4
         with:
-          name: release-binary-${{ inputs.destination }}${{ runner.os == 'Windows' && !endsWith(inputs.destination, '.exe') && '.exe' || '' }}"
-          overwrite: true
-          path: /tmp/release-binary/${{ inputs.destination }}${{ runner.os == 'Windows' && !endsWith(inputs.destination, '.exe') && '.exe' || '' }}"
+          name: ${{ inputs.upload-name }}
+          path: /tmp/deploy-artifacts/${{ github.sha }}/*
           if-no-files-found: error
-          retention-days: 1

.github/workflows/deploy-s3.yml

@@ -1,4 +1,4 @@
-name: Release Binary
+name: Deploy S3
 
 on:
   workflow_call:
@@ -33,7 +33,7 @@ jobs:
       - name: Create and enter path
         run: |
           mkdir -p /tmp/deploy-s3/${{ github.sha }}
-          cd /tmp/${{ github.sha }}
+          cd /tmp/deploy-s3/${{ github.sha }}
       - name: Download binaries
         id: download-artifacts
         uses: actions/download-artifact@v4

.github/workflows/generate-checksums.yml

@@ -48,22 +48,22 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
       - name: Ensure path
-        run: mkdir -p /tmp/${{ github.sha }}
+        run: mkdir -p /tmp/checksums/${{ github.sha }}
       - name: Download artifacts
         uses: actions/download-artifact@v4
         with:
           name: ${{ inputs.download-name }}
-          path: /tmp/${{ github.sha }}
+          path: /tmp/checksums/${{ github.sha }}
           pattern: ${{ inputs.download-pattern }}
           merge-multiple: ${{ inputs.flatten }}
       - name: Verify files
         run: |
           echo "::group::Organized checksummed files"
-          ls -lsa /tmp/${{ github.sha }}
+          ls -lsa /tmp/checksums/${{ github.sha }}
           echo "::endgroup::"
       - name: Checksum files
         run: |
-          cd /tmp/${{ github.sha }}
+          /tmp/checksums/${{ github.sha }}
           bash ${{ github.workspace }}/scripts/generate-checksums.sh \
             --depth=${{ inputs.depth }} \
             --output=/tmp/${{ inputs.output }} \
@@ -72,6 +72,6 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: ${{ inputs.upload-name }}
-          path: /tmp/${{ inputs.output }}
+          path: /tmp/checksums/${{ github.sha }}/${{ inputs.output }}
           if-no-files-found: error
           retention-days: 1

.github/workflows/release-binary.yml

@@ -28,31 +28,31 @@ jobs:
     env:
       TERM: xterm
     steps:
-      - name: Create and enter path
+      - name: Create paths
         run: |
-          mkdir -p /tmp/${{ github.sha }}
-          cd /tmp/${{ github.sha }}
+          mkdir -p /tmp/release-binary-source/${{ github.sha }}
+          mkdir -p /tmp/release-binary-destination/${{ github.sha }}
       - name: Download binaries
         id: download-artifacts
         uses: actions/download-artifact@v4
         with:
           name: ${{ inputs.download-name }}
           merge-multiple: true
-          path: /tmp/${{ github.sha }}
+          path: /tmp/release-binary-source/${{ github.sha }}
           pattern: ${{ inputs.download-pattern }}
       - name: Mod as needed
         run: |
           mkdir -p /tmp/release-binary
           cp -rf \
-            "/tmp/${{ github.sha }}/${{ inputs.source }}${{ runner.os == 'Windows' && !endsWith(inputs.source, '.exe') && '.exe' || '' }}" \
-            "/tmp/release-binary/${{ inputs.destination }}${{ runner.os == 'Windows' && !endsWith(inputs.destination, '.exe') && '.exe' || '' }}"
-          chmod +x /tmp/release-binary/*
-          ls -lsa /tmp/release-binary
+            "/tmp/release-binary-source/${{ github.sha }}}/${{ inputs.source }}${{ runner.os == 'Windows' && !endsWith(inputs.source, '.exe') && '.exe' || '' }}" \
+            "/tmp/release-binary-destination/${{ github.sha }}/${{ inputs.destination }}${{ runner.os == 'Windows' && !endsWith(inputs.destination, '.exe') && '.exe' || '' }}"
+          chmod +x /tmp/release-binary-destination/${{ github.sha }}/*
+          ls -lsa /tmp/release-binary-destination/${{ github.sha }}
       - name: Upload signed binaries
         uses: actions/upload-artifact@v4
         with:
           name: release-binary-${{ inputs.destination }}${{ runner.os == 'Windows' && !endsWith(inputs.destination, '.exe') && '.exe' || '' }}"
           overwrite: true
-          path: /tmp/release-binary/${{ inputs.destination }}${{ runner.os == 'Windows' && !endsWith(inputs.destination, '.exe') && '.exe' || '' }}"
+          path: /tmp/release-binary/${{ github.sha }}/${{ inputs.destination }}${{ runner.os == 'Windows' && !endsWith(inputs.destination, '.exe') && '.exe' || '' }}"
           if-no-files-found: error
           retention-days: 1

.github/workflows/sign-binary.yml

@@ -58,15 +58,15 @@ jobs:
         uses: actions/checkout@v4
       - name: Create and enter path
         run: |
-          mkdir -p /tmp/${{ github.sha }}
-          cd /tmp/${{ github.sha }}
+          mkdir -p /tmp/sign/${{ github.sha }}
+          cd /tmp/sign/${{ github.sha }}
       - name: Download binaries
         id: download-artifacts
         uses: actions/download-artifact@v4
         with:
           name: ${{ inputs.download-name }}
           merge-multiple: true
-          path: /tmp/${{ github.sha }}
+          path: /tmp/sign/${{ github.sha }}
           pattern: ${{ inputs.download-pattern }}
       - name: Sign and Notarize
         id: code-sign-action
@@ -90,6 +90,6 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: signed-${{ inputs.file }}
-          path: /tmp/${{ github.sha }}/${{ inputs.file }}${{ runner.os == 'Windows' && !endsWith(inputs.file, '.exe') && '.exe' || '' }}
+          path: /tmp/sign/${{ github.sha }}/${{ inputs.file }}${{ runner.os == 'Windows' && !endsWith(inputs.file, '.exe') && '.exe' || '' }}
           if-no-files-found: error
           retention-days: 1