Merge pull request #14 from WoltLab/missing-text-not-null

Ocramius · web-flow · commit cb57c459f3c2 · 2022-07-28T11:25:14.000+02:00
Do not pass `null` to the `$text` parameter of adapter's `notify()`
diff --git a/src/ProgressBar.php b/src/ProgressBar.php
@@ -42,7 +42,7 @@ class ProgressBar
      *
      * @var string
      */
-    protected $statusText = null;
+    protected $statusText = '';
 
     /**
      * Adapter for the output
diff --git a/test/ProgressBarTest.php b/test/ProgressBarTest.php
@@ -80,6 +80,13 @@ public function testEtaZeroPercent()
         $this->assertEquals(null, $progressBar->getTimeRemaining());
     }
 
+    public function testMissingTextIsNotNull()
+    {
+        $progressBar = $this->_getProgressBar(0, 100);
+
+        $this->assertSame('', $progressBar->getText());
+    }
+
     // @codingStandardsIgnoreStart
     protected function _getProgressBar($min, $max, $persistenceNamespace = null)
     {

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,13 @@ public function testEtaZeroPercent()`
`80`	`80`	`$this->assertEquals(null, $progressBar->getTimeRemaining());`
`81`	`81`	`}`
`82`	`82`
	`83`	`+ public function testMissingTextIsNotNull()`
	`84`	`+ {`
	`85`	`+ $progressBar = $this->_getProgressBar(0, 100);`
	`86`	`+`
	`87`	`+ $this->assertSame('', $progressBar->getText());`
	`88`	`+ }`
	`89`	`+`
`83`	`90`	`// @codingStandardsIgnoreStart`
`84`	`91`	`protected function _getProgressBar($min, $max, $persistenceNamespace = null)`
`85`	`92`	`{`