Skip to content

Refactor of Zend\Db\ResultSet for 3.0.0 #12

Closed
@weierophinney

Description

@weierophinney

This PR provides changes described in #364

I have two questions from refactoring.

  1. Return type hints for implementations of \Iterator::current() is incomplete due to inconsistent usage. Right now, type hints are only documented in method comment. Either leave it or a change is required to match return types.
  • Iterator::current() documents a mixed (any) type
  • AbstractResultSet::current() documents array|null
  • ResultSet::current() documents array|ArrayObject|null
  • HydratingResultSet::current() documents null|array|bool
  1. ExtractionInterface::extract() expects parameter be of type object. From my understanding HydratingResultSet::toArray() could give provide any of null|array|bool. Not sure if I misunderstand it or if that needs some attention.

Originally posted by @arueckauer at zendframework/zend-db#370

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions