diff --git a/src/arch.rs b/src/arch.rs index 384d77706..1d5987922 100644 --- a/src/arch.rs +++ b/src/arch.rs @@ -114,7 +114,7 @@ impl AbiArgument for ValueWithInfoWrapper<'_> { .to_bytes(buffer, find_dict_drop_override)?, (Value::Array(_), CoreTypeConcrete::Array(_)) => { - // TODO: Assert that `info.ty` matches all the values' types. + // TODO: Assert that `info.ty` matches all the values' types. See: https://github.com/lambdaclass/cairo_native/issues/1216 let abi_ptr = self.value.to_ptr( self.arena, @@ -130,6 +130,7 @@ impl AbiArgument for ValueWithInfoWrapper<'_> { abi.capacity.to_bytes(buffer, find_dict_drop_override)?; } (Value::BoundedInt { .. }, CoreTypeConcrete::BoundedInt(_)) => { + // See: https://github.com/lambdaclass/cairo_native/issues/1217 native_panic!("todo: implement AbiArgument for Value::BoundedInt case") } (Value::Bytes31(value), CoreTypeConcrete::Bytes31(_)) => { diff --git a/src/bin/cairo-native-stress/main.rs b/src/bin/cairo-native-stress/main.rs index 349e6c213..b6757b1a7 100644 --- a/src/bin/cairo-native-stress/main.rs +++ b/src/bin/cairo-native-stress/main.rs @@ -103,7 +103,6 @@ fn main() { let before_round = Instant::now(); let program = modify_starknet_contract(program.clone(), UNIQUE_CONTRACT_VALUE, round); - // TODO: use the program hash instead of round number. let hash = round; debug!(hash, "obtained test program"); diff --git a/src/executor.rs b/src/executor.rs index 7ac66cd6b..10894629e 100644 --- a/src/executor.rs +++ b/src/executor.rs @@ -265,7 +265,7 @@ fn invoke_dynamic( _ if type_info.is_builtin() => { if !type_info.is_zst(registry)? { if let CoreTypeConcrete::BuiltinCosts(_) = type_info { - // todo: should we use this value? + // todo: should we use this value? See: https://github.com/lambdaclass/cairo_native/issues/1219 let _value = match &mut return_ptr { Some(return_ptr) => unsafe { *read_value::<*mut u64>(return_ptr) }, None => ret_registers[0] as *mut u64, diff --git a/src/executor/contract.rs b/src/executor/contract.rs index 9e93bbe50..b53e06a2e 100644 --- a/src/executor/contract.rs +++ b/src/executor/contract.rs @@ -729,7 +729,7 @@ mod tests { use rayon::iter::ParallelBridge; use rstest::*; - // todo add recursive contract test + // todo add recursive contract test See: https://github.com/lambdaclass/cairo_native/issues/1220 #[fixture] fn starknet_program() -> ContractClass { diff --git a/src/libfuncs/bytes31.rs b/src/libfuncs/bytes31.rs index 66006c87a..d64cbeb3f 100644 --- a/src/libfuncs/bytes31.rs +++ b/src/libfuncs/bytes31.rs @@ -170,7 +170,7 @@ mod test { use starknet_types_core::felt::Felt; lazy_static! { - // TODO: Test `bytes31_const` once the compiler supports it. + // TODO: Test `bytes31_const` once the compiler supports it. See: https://github.com/lambdaclass/cairo_native/issues/1224 static ref BYTES31_ROUNDTRIP: (String, Program) = load_cairo! { use core::bytes_31::{bytes31_try_from_felt252, bytes31_to_felt252}; diff --git a/src/libfuncs/felt252.rs b/src/libfuncs/felt252.rs index 65f079bdc..7604ce09d 100644 --- a/src/libfuncs/felt252.rs +++ b/src/libfuncs/felt252.rs @@ -364,10 +364,10 @@ pub mod test { } }; - // TODO: Add test program for `felt252_add_const`. - // TODO: Add test program for `felt252_sub_const`. - // TODO: Add test program for `felt252_mul_const`. - // TODO: Add test program for `felt252_div_const`. + // TODO: Add test program for `felt252_add_const`. See: https://github.com/lambdaclass/cairo_native/issues/1214 + // TODO: Add test program for `felt252_sub_const`. See: https://github.com/lambdaclass/cairo_native/issues/1214 + // TODO: Add test program for `felt252_mul_const`. See: https://github.com/lambdaclass/cairo_native/issues/1214 + // TODO: Add test program for `felt252_div_const`. See: https://github.com/lambdaclass/cairo_native/issues/1214 static ref FELT252_CONST: (String, Program) = load_cairo! { extern fn felt252_const() -> felt252 nopanic; diff --git a/src/starknet.rs b/src/starknet.rs index dfc4e42cc..131439f63 100644 --- a/src/starknet.rs +++ b/src/starknet.rs @@ -53,7 +53,7 @@ impl From<&Felt252Abi> for Felt { } /// Binary representation of a `u256` (in MLIR). -// TODO: This shouldn't need to be public. +// TODO: This shouldn't need to be public. See: https://github.com/lambdaclass/cairo_native/issues/1221 #[derive( Debug, Clone, @@ -557,7 +557,7 @@ impl StarknetSyscallHandler for DummySyscallHandler { } } -// TODO: Move to the correct place or remove if unused. +// TODO: Move to the correct place or remove if unused. See: https://github.com/lambdaclass/cairo_native/issues/1222 pub(crate) mod handler { use super::*; use crate::utils::{libc_free, libc_malloc}; diff --git a/src/types/enum.rs b/src/types/enum.rs index 213df2e8e..98768fd4b 100644 --- a/src/types/enum.rs +++ b/src/types/enum.rs @@ -761,7 +761,8 @@ pub fn get_layout_for_variants( /// Extract the type and layout for the default enum representation, its discriminant and all its /// payloads. // TODO: Change this function to accept a slice of slices (for variants). Not all uses have a slice -// with one `ConcreteTypeId` per variant (deploy_syscalls has two types for the Ok() variant). +// with one `ConcreteTypeId` per variant (deploy_syscalls has two types for the Ok() variant). +// See: https://github.com/lambdaclass/cairo_native/issues/1187/ pub fn get_type_for_variants<'ctx>( context: &'ctx Context, module: &Module<'ctx>, diff --git a/src/types/starknet.rs b/src/types/starknet.rs index c99a47363..6593cf48c 100644 --- a/src/types/starknet.rs +++ b/src/types/starknet.rs @@ -19,7 +19,7 @@ //! ## Secp256Point //! TODO -// TODO: Maybe the types used here can be i251 instead of i252. +// TODO: Maybe the types used here can be i251 instead of i252. See https://github.com/lambdaclass/cairo_native/issues/1226 use super::WithSelf; use crate::{