Skip to content

Commit 8a769b4

Browse files
committed
xml: rename xpath functions
s/xml_add_node/xpath_add_node/ s/get_node/xpath_get_node/ s/xml_get_content/xpath_get_content/
1 parent 0f98655 commit 8a769b4

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

tests/t1000-add-xpath-node.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ int main(int argc, char **argv)
4949
/* test 1 */
5050
diag("add node <theme><cornerradius> using xpath (lowercase)");
5151
xml_init(in);
52-
xml_add_node("/labwc_config/theme/cornerradius");
52+
xpath_add_node("/labwc_config/theme/cornerradius");
5353
xml_save_as(out);
5454
xml_finish();
5555
test(out,
@@ -66,7 +66,7 @@ int main(int argc, char **argv)
6666
/* test 2 */
6767
diag("add node <theme><cornerRadius> using xpath (camelCase)");
6868
xml_init(in);
69-
xml_add_node("/labwc_config/theme/cornerRadius");
69+
xpath_add_node("/labwc_config/theme/cornerRadius");
7070
xml_save_as(out);
7171
xml_finish();
7272
test(out,
@@ -83,8 +83,8 @@ int main(int argc, char **argv)
8383
/* test 3 */
8484
diag("check xpath does not add duplicate entries - when identical");
8585
xml_init(in);
86-
xml_add_node("/labwc_config/theme/cornerradius");
87-
xml_add_node("/labwc_config/theme/cornerradius");
86+
xpath_add_node("/labwc_config/theme/cornerradius");
87+
xpath_add_node("/labwc_config/theme/cornerradius");
8888
xml_save_as(out);
8989
xml_finish();
9090
test(out,
@@ -101,8 +101,8 @@ int main(int argc, char **argv)
101101
/* test 4 */
102102
diag("check xpath does not add duplicate entries - even if they have differing capitalisation");
103103
xml_init(in);
104-
xml_add_node("/labwc_config/theme/cornerradius");
105-
xml_add_node("/labwc_config/theme/Cornerradius");
104+
xpath_add_node("/labwc_config/theme/cornerradius");
105+
xpath_add_node("/labwc_config/theme/Cornerradius");
106106
xml_save_as(out);
107107
xml_finish();
108108
test(out,

tests/t1001-nodenames.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ int main(int argc, char **argv)
3737
/* test 1 */
3838
diag("generate simple xpath style nodename");
3939
xml_init(in);
40-
xmlNode *node = get_node((xmlChar *)"/labwc_config/core/gap");
40+
xmlNode *node = xpath_get_node((xmlChar *)"/labwc_config/core/gap");
4141
char *name = nodename(node, buffer, sizeof(buffer));
4242
xml_finish();
4343
test(name, "/labwc_config/core/gap");

xml.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ xml_get_node(char *nodename)
231231
}
232232

233233
char *
234-
xml_get_content(char *xpath_expr)
234+
xpath_get_content(char *xpath_expr)
235235
{
236236
xmlChar *ret = NULL;
237237
xmlXPathObjectPtr object = xmlXPathEvalExpression((xmlChar *)xpath_expr, ctx.xpath_ctx_ptr);
@@ -266,7 +266,7 @@ xml_get_content(char *xpath_expr)
266266

267267
/* case-sensitive */
268268
static xmlNode *
269-
get_node(xmlChar *expr)
269+
xpath_get_node(xmlChar *expr)
270270
{
271271
xmlNode *ret = NULL;
272272
xmlXPathObjectPtr object = xmlXPathEvalExpression(expr, ctx.xpath_ctx_ptr);
@@ -292,7 +292,7 @@ get_node(xmlChar *expr)
292292
}
293293

294294
void
295-
xml_add_node(char *xpath_expr)
295+
xpath_add_node(char *xpath_expr)
296296
{
297297
if (xml_get_node(xpath_expr)) {
298298
return;
@@ -302,7 +302,7 @@ xml_add_node(char *xpath_expr)
302302
char *parent_expr = strdup(xpath_expr);
303303
xmlNode *parent_node = NULL;
304304
while (parent_expr && *parent_expr) {
305-
parent_node = get_node((xmlChar *)parent_expr);
305+
parent_node = xpath_get_node((xmlChar *)parent_expr);
306306
if (parent_node) {
307307
break;
308308
}

xml.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,17 @@ int xml_get_int(char *nodename);
1212
int xml_get_bool_text(char *nodename);
1313

1414
/**
15-
* xml_get_content - get content of node specified by xpath
15+
* xpath_get_content() - Get content of node specified by xpath
1616
* @xpath_expr: xpath expression for node
1717
*/
18-
char *xml_get_content(char *xpath_expr);
18+
char *xpath_get_content(char *xpath_expr);
1919

2020
/**
21-
* xml_add_node - add xml nodes from xpath
21+
* xpath_add_node - add xml nodes from xpath
2222
* @xpath_expr: xpath expression for new node
2323
* For example xpath_expr="/labwc_config/a/b/c" creates
2424
* <labwc_config><a><b><c /></b></a></labwc_config>
2525
*/
26-
void xml_add_node(char *xpath_expr);
26+
void xpath_add_node(char *xpath_expr);
2727

2828
#endif /* __XML_H */

0 commit comments

Comments
 (0)