Skip to content

Commit db57331

Browse files
resolve conflicts and add namespace prefix
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
1 parent 386cab0 commit db57331

File tree

3 files changed

+30
-6
lines changed

3 files changed

+30
-6
lines changed

e2e/fleet_attachedcluster_test.go

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ limitations under the License.
1717
package e2e
1818

1919
import (
20+
"time"
21+
2022
"github.com/onsi/ginkgo/v2"
2123
"github.com/onsi/gomega"
2224
corev1 "k8s.io/api/core/v1"
@@ -27,11 +29,13 @@ import (
2729

2830
var _ = ginkgo.Describe("[AttachedClusters] AttachedClusters testing", func() {
2931
var (
30-
fleetname string
31-
fleet *fleetv1a1.Fleet
32+
fleetNamespace string
33+
fleetname string
34+
fleet *fleetv1a1.Fleet
3235
)
3336

3437
ginkgo.BeforeEach(func() {
38+
fleetNamespace = e2ePrefix + resources.RandomNamespace(4)
3539
fleetname = "e2e"
3640
// build fleet
3741
clusters := []*corev1.ObjectReference{
@@ -40,11 +44,11 @@ var _ = ginkgo.Describe("[AttachedClusters] AttachedClusters testing", func() {
4044
Kind: "AttachedCluster",
4145
},
4246
}
43-
fleet = resources.NewFleet(namespace, fleetname, clusters)
47+
fleet = resources.NewFleet(fleetNamespace, fleetname, clusters)
4448
})
4549

4650
ginkgo.AfterEach(func() {
47-
fleerRemoveErr := resources.RemoveFleet(kuratorClient, namespace, fleetname)
51+
fleerRemoveErr := resources.RemoveFleet(kuratorClient, fleetNamespace, fleetname)
4852
gomega.Expect(fleerRemoveErr).ShouldNot(gomega.HaveOccurred())
4953

5054
attachedclusterRemoveErr := resources.RemoveAttachedCluster(kuratorClient, namespace, memberClusterName)
@@ -53,15 +57,20 @@ var _ = ginkgo.Describe("[AttachedClusters] AttachedClusters testing", func() {
5357
secretRemoveErr := resources.RemoveSecret(kubeClient, namespace, memberClusterName)
5458
gomega.Expect(secretRemoveErr).ShouldNot(gomega.HaveOccurred())
5559

56-
namespaceRemoveErr := resources.RemoveNamespace(kubeClient, namespace)
60+
namespaceRemoveErr := resources.RemoveNamespace(kubeClient, fleetNamespace)
5761
gomega.Expect(namespaceRemoveErr).ShouldNot(gomega.HaveOccurred())
5862
})
5963

6064
ginkgo.It("Create Fleet", func() {
65+
// create a namespace for fleet e2e test
66+
fleetNamespaceCfg := resources.NewNamespace(fleetNamespace)
67+
createNSErr := resources.CreateNamespace(kubeClient, fleetNamespaceCfg)
68+
gomega.Expect(createNSErr).ShouldNot(gomega.HaveOccurred())
69+
time.Sleep(3 * time.Second)
6170
// create fleet and checkout fleet status
6271
fleetCreateErr := resources.CreateFleet(kuratorClient, fleet)
6372
gomega.Expect(fleetCreateErr).ShouldNot(gomega.HaveOccurred())
64-
resources.WaitFleetFitWith(kuratorClient, namespace, fleetname, func(fleet *fleetv1a1.Fleet) bool {
73+
resources.WaitFleetFitWith(kuratorClient, fleetNamespace, fleetname, func(fleet *fleetv1a1.Fleet) bool {
6574
return fleet.Status.Phase == fleetv1a1.ReadyPhase
6675
})
6776
})

e2e/resources/namespace.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,17 @@ package resources
1818

1919
import (
2020
"context"
21+
"math/rand"
22+
"strings"
2123

2224
corev1 "k8s.io/api/core/v1"
2325
apierrors "k8s.io/apimachinery/pkg/api/errors"
2426
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2527
"k8s.io/client-go/kubernetes"
2628
)
2729

30+
const chartSet = "abcdefghijklmnopqrstuvwxyz"
31+
2832
// NewNamespace will build a Namespace object.
2933
func NewNamespace(namespace string) *corev1.Namespace {
3034
return &corev1.Namespace{
@@ -57,3 +61,12 @@ func RemoveNamespace(client kubernetes.Interface, name string) error {
5761
}
5862
return nil
5963
}
64+
65+
func RandomNamespace(nameLength int) string {
66+
randomNS := strings.Builder{}
67+
randomNS.Grow(nameLength)
68+
for i := 0; i < nameLength; i++ {
69+
randomNS.WriteByte(chartSet[rand.Intn(len(chartSet))])
70+
}
71+
return randomNS.String()
72+
}

e2e/suite_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ var (
4040
kuratorContext string
4141

4242
namespace string
43+
e2ePrefix string
4344
memberClusterName string
4445
kubeconfigPath string
4546
secret *corev1.Secret
@@ -67,6 +68,7 @@ var _ = ginkgo.SynchronizedBeforeSuite(func() []byte {
6768
gomega.Expect(err).ShouldNot(gomega.HaveOccurred())
6869

6970
namespace = "e2e-test"
71+
e2ePrefix = "e2e-"
7072
memberClusterName = "kurator-member"
7173
homeDir, err := os.UserHomeDir()
7274
gomega.Expect(err).ShouldNot(gomega.HaveOccurred())

0 commit comments

Comments
 (0)