Obey clippy::comparison_chain

Author: kulp

tyrga-lib/src/lib.rs

@@ -16,6 +16,7 @@
 #![deny(unused_mut)]
 #![deny(unused_variables)]
 #![deny(clippy::inefficient_to_string)]
+#![deny(clippy::comparison_chain)]
 
 // make macros visible to later modules
 #[macro_use]

tyrga-lib/src/stack.rs

@@ -76,6 +76,7 @@ impl Manager {
     fn nudge(&mut self, pick_movement : i32, depth_movement : i32) -> StackActions {
         use crate::tenyr::InstructionType::Type3;
         use crate::tenyr::MemoryOpType::{LoadRight, NoLoad, StoreRight};
+        use std::cmp::Ordering::*;
 
         let spilled_before = self.spilled_count();
 
@@ -111,17 +112,18 @@ impl Manager {
             kind : Type3(off),
         });
 
-        if n < 0 {
-            update
-                .chain((spilled_before..spilled_after).map(mover(StoreRight, spilled_before)))
-                .collect()
-        } else if n > 0 {
-            (spilled_after..spilled_before)
-                .map(mover(LoadRight, spilled_after))
-                .chain(update)
-                .collect()
-        } else {
-            std::iter::empty().collect()
+        match n.cmp(&0) {
+            Less =>
+                update
+                    .chain((spilled_before..spilled_after).map(mover(StoreRight, spilled_before)))
+                    .collect(),
+            Equal =>
+                std::iter::empty().collect(),
+            Greater =>
+                (spilled_after..spilled_before)
+                    .map(mover(LoadRight, spilled_after))
+                    .chain(update)
+                    .collect(),
         }
     }