Obey clippy::inefficient_to_string

kulp · kulp · commit 02acf2d503a3 · 2020-02-07T16:11:24.000-07:00
diff --git a/tyrga-lib/src/lib.rs b/tyrga-lib/src/lib.rs
@@ -15,6 +15,7 @@
 #![deny(bare_trait_objects)]
 #![deny(unused_mut)]
 #![deny(unused_variables)]
+#![deny(clippy::inefficient_to_string)]
 
 // make macros visible to later modules
 #[macro_use]
@@ -1171,7 +1172,8 @@ mod util {
     }
 
     impl Manglable for &str {
-        fn pieces(&self) -> Vec<String> { vec![ self.to_string() ] }
+        // Dereference self explicitly to get faster ToString implementation
+        fn pieces(&self) -> Vec<String> { vec![ (*self).to_string() ] }
     }
 
     impl Manglable for String {

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@`
`15`	`15`	`#![deny(bare_trait_objects)]`
`16`	`16`	`#![deny(unused_mut)]`
`17`	`17`	`#![deny(unused_variables)]`
	`18`	`+#![deny(clippy::inefficient_to_string)]`
`18`	`19`
`19`	`20`	`// make macros visible to later modules`
`20`	`21`	`#[macro_use]`
`@@ -1171,7 +1172,8 @@ mod util {`
`1171`	`1172`	`}`
`1172`	`1173`
`1173`	`1174`	`impl Manglable for &str {`
`1174`		`- fn pieces(&self) -> Vec<String> { vec![ self.to_string() ] }`
	`1175`	`+ // Dereference self explicitly to get faster ToString implementation`
	`1176`	`+ fn pieces(&self) -> Vec<String> { vec![ (*self).to_string() ] }`
`1175`	`1177`	`}`
`1176`	`1178`
`1177`	`1179`	`impl Manglable for String {`