Skip to content

Commit f3156a6

Browse files
github-actions[bot]Create or Update Pull Request Actionkuelumbus
authored
🤖 Bump RDKit version to Release_2024_09_4 (#119) [skip ci]
* Set RDKit version to Release_2024_09_4 * Number of descriptors has changed * Set MACOSX_DEPLOYMENT_TARGET to 10.15 for macOS x86_64 * Adjust macos dev target [skip ci] --------- Co-authored-by: Create or Update Pull Request Action <create-or-update-pull-request@users.noreply.github.com> Co-authored-by: Christopher Kuenneth <christopher.kuenneth@gmail.com> Co-authored-by: Chris Kuenneth <44866753+kuelumbus@users.noreply.github.com>
1 parent 667ab44 commit f3156a6

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Please open an issue if you find something missing or not working as expected.
2222
| ------- | ------- | --- | --------------------------------------------------- | -------------- | --- | ---- | ---- | ---- | ---- | -------------- |
2323
| Linux | intel | 64 | glibc >= 2.28 (e.g., Ubuntu 18.04+, CentOS 6+, ...) | last: 2024.3.5 | ✔️ | ✔️ | ✔️ | ✔️ | ✔️ | Github Actions |
2424
| Linux | aarch64 | 64 | glibc >= 2.28 (e.g., Raspberry Pi, ...) | last: 2024.3.5 | ✔️ | ✔️ | ✔️ | ✔️ | ✔️ | Circle CI |
25-
| macOS | intel | 64 | >= macOS 10.13 | last: 2024.3.5 | ✔️ | ✔️ | ✔️ | ✔️ | ✔️ | Github Actions |
25+
| macOS | intel | 64 | >= macOS 10.15 | last: 2024.3.5 | ✔️ | ✔️ | ✔️ | ✔️ | ✔️ | Github Actions |
2626
| macOS | armv8 | 64 | >= macOS 11, M1 hardware | last: 2024.3.5 | ✔️ | ✔️ | ✔️ | ✔️ | ✔️ | Github Actions |
2727
| Windows | intel | 64 | | last: 2024.3.5 | ✔️ | ✔️ | ✔️ | ✔️ | ✔️ | Github Actions |
2828

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ repair-wheel-command = [
5555
# The delocate-wheel command verifies the MACOSX_DEPLOYMENT_TARGET version of the libraries.
5656
# Since the build platform's macOS version differs from the deployment target, we need to specify it explicitly here.
5757
# delocate reads the target from the environment variable.
58-
# The target for x86_64 is set to 10.13.
59-
environment = { MACOSX_DEPLOYMENT_TARGET="10.13" }
58+
# The target for x86_64 is set to 10.15.
59+
environment = { MACOSX_DEPLOYMENT_TARGET="10.15" }
6060

6161
[[tool.cibuildwheel.overrides]]
6262
# The target for arm64 is 11.0

setup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from setuptools.command.build_ext import build_ext as build_ext_orig
1313

1414
# RDKit version to build (tag from github repository)
15-
rdkit_tag = "Release_2024_09_3"
15+
rdkit_tag = "Release_2024_09_4"
1616

1717
with open("README.md", "r", encoding="utf-8") as fh:
1818
long_description = fh.read()
@@ -266,7 +266,7 @@ def to_win_path(pt: Path):
266266
options += [
267267
# macOS < 10.13 has a incomplete C++17 implementation
268268
# See https://github.com/kuelumbus/rdkit-pypi/pull/85 for a discussion
269-
f"-DCMAKE_OSX_DEPLOYMENT_TARGET={os.environ.get('MACOSX_DEPLOYMENT_TARGET', '10.13')}",
269+
f"-DCMAKE_OSX_DEPLOYMENT_TARGET={os.environ.get('MACOSX_DEPLOYMENT_TARGET', '10.15')}",
270270
]
271271

272272
# Modifications for MacOS arm64 (M1 hardware)

tests/test_main.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ def test_descriptor():
44
from rdkit.Chem import Descriptors
55
# Was 209 but changed to 211 in Release_2023_09_1
66
# Is 210 from Release_2023_09_3
7-
assert len(Descriptors._descList) == 210
7+
# Is 217 from Release_2024_09_4
8+
assert len(Descriptors._descList) == 217
89

910

1011
def test_3d_descriptors():

0 commit comments

Comments
 (0)