From b787b005a7ff8d5e4123e1f97534dfa40cb5cd07 Mon Sep 17 00:00:00 2001 From: xuqingyun Date: Mon, 5 Aug 2024 19:11:35 +0800 Subject: [PATCH] feat: remove path tag for termination metric --- pkg/gateway/metrics/prometheus.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/gateway/metrics/prometheus.go b/pkg/gateway/metrics/prometheus.go index 71e4743..d98c248 100644 --- a/pkg/gateway/metrics/prometheus.go +++ b/pkg/gateway/metrics/prometheus.go @@ -98,7 +98,7 @@ var ( Help: "Number of requests which proxy terminated in self-defense.", StabilityLevel: compbasemetrics.ALPHA, }, - []string{"pid", "serverName", "verb", "path", "code", "reason", "resource", "flowcontrol"}, + []string{"pid", "serverName", "verb", "code", "reason", "resource", "flowcontrol"}, ) // proxyRegisteredWatchers is a number of currently registered watchers splitted by resource. proxyRegisteredWatchers = compbasemetrics.NewGaugeVec( @@ -262,7 +262,7 @@ func (o *proxyResponseSizesObserver) Observe(metric MetricInfo) { type proxyRequestTerminationsObserver struct{} func (o *proxyRequestTerminationsObserver) Observe(metric MetricInfo) { - proxyRequestTerminationsTotal.WithLabelValues(proxyPid, metric.ServerName, metric.Verb, metric.Path, metric.HttpCode, metric.Reason, metric.Resource, metric.FlowControl).Inc() + proxyRequestTerminationsTotal.WithLabelValues(proxyPid, metric.ServerName, metric.Verb, metric.HttpCode, metric.Reason, metric.Resource, metric.FlowControl).Inc() } type proxyWatcherRegisteredObserver struct{}