Skip to content

Commit d5ebb56

Browse files
authored
Merge pull request #655 from yadzhang/feat/remove_dropcache_migrate_numa
feat(qrm): remove dropcache when migrate numa memory
2 parents ee1cc39 + d7ff93b commit d5ebb56

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

pkg/agent/qrm-plugins/memory/dynamicpolicy/policy_allocation_handlers.go

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ import (
2929
"github.com/kubewharf/katalyst-core/pkg/agent/qrm-plugins/memory/dynamicpolicy/state"
3030
"github.com/kubewharf/katalyst-core/pkg/agent/qrm-plugins/util"
3131
"github.com/kubewharf/katalyst-core/pkg/util/asyncworker"
32-
cgroupmgr "github.com/kubewharf/katalyst-core/pkg/util/cgroup/manager"
3332
"github.com/kubewharf/katalyst-core/pkg/util/general"
3433
"github.com/kubewharf/katalyst-core/pkg/util/machine"
3534
qosutil "github.com/kubewharf/katalyst-core/pkg/util/qos"
@@ -482,21 +481,6 @@ func (p *DynamicPolicy) adjustAllocationEntries() error {
482481
general.Errorf("add work: %s pod: %s container: %s failed with error: %v", movePagesWorkName, podUID, containerName, err)
483482
}
484483
}
485-
486-
dropCacheWorkName := util.GetContainerAsyncWorkName(podUID, containerName,
487-
memoryPluginAsyncWorkTopicDropCache)
488-
// start a asynchronous work to drop cache for the container whose numaset changed and doesn't require numa_binding
489-
err = p.defaultAsyncLimitedWorkers.AddWork(
490-
&asyncworker.Work{
491-
Name: dropCacheWorkName,
492-
UID: uuid.NewUUID(),
493-
Fn: cgroupmgr.DropCacheWithTimeoutForContainer,
494-
Params: []interface{}{podUID, containerID, dropCacheTimeoutSeconds, GetFullyDropCacheBytes(container)},
495-
DeliveredAt: time.Now(),
496-
}, asyncworker.DuplicateWorkPolicyOverride)
497-
if err != nil {
498-
general.Errorf("add work: %s pod: %s container: %s failed with error: %v", dropCacheWorkName, podUID, containerName, err)
499-
}
500484
}
501485
}
502486

0 commit comments

Comments
 (0)