Skip to content

Commit cdf8732

Browse files
authored
Merge pull request #783 from funnydreamwinz/dev/fix-ut
fix(sysadvisor): fix unit test failed of get headroom
2 parents 3c1d4db + 6980bb5 commit cdf8732

File tree

1 file changed

+95
-0
lines changed

1 file changed

+95
-0
lines changed

pkg/agent/sysadvisor/plugin/qosaware/resource/cpu/assembler/headroomassembler/assembler_common_test.go

Lines changed: 95 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,23 @@ func TestHeadroomAssemblerCommon_GetHeadroom(t *testing.T) {
137137
consts.ReclaimedResourceMilliCPU: resource.MustParse("10000"),
138138
},
139139
},
140+
TopologyZone: []*v1alpha1.TopologyZone{
141+
{
142+
Type: "Socket",
143+
Name: "0",
144+
Children: []*v1alpha1.TopologyZone{
145+
{
146+
Type: "Numa",
147+
Name: "0",
148+
Resources: v1alpha1.Resources{
149+
Allocatable: &v1.ResourceList{
150+
consts.ReclaimedResourceMilliCPU: resource.MustParse("10000"),
151+
},
152+
},
153+
},
154+
},
155+
},
156+
},
140157
},
141158
},
142159
reclaimedResourceConfiguration: &reclaimedresource.ReclaimedResourceConfiguration{
@@ -154,6 +171,7 @@ func TestHeadroomAssemblerCommon_GetHeadroom(t *testing.T) {
154171
for i := 0; i < 10; i++ {
155172
store.SetCPUMetric(i, pkgconsts.MetricCPUUsageRatio, utilmetric.MetricData{Value: 0.3, Time: &now})
156173
}
174+
store.SetCgroupMetric("/kubepods/besteffort-0", pkgconsts.MetricCPUUsageCgroup, utilmetric.MetricData{Value: 3, Time: &now})
157175
store.SetCgroupMetric("/kubepods/besteffort", pkgconsts.MetricCPUUsageCgroup, utilmetric.MetricData{Value: 3, Time: &now})
158176
},
159177
setMetaCache: func(cache *metacache.MetaCacheImp) {
@@ -190,6 +208,23 @@ func TestHeadroomAssemblerCommon_GetHeadroom(t *testing.T) {
190208
consts.ReclaimedResourceMilliCPU: resource.MustParse("10000"),
191209
},
192210
},
211+
TopologyZone: []*v1alpha1.TopologyZone{
212+
{
213+
Type: "Socket",
214+
Name: "0",
215+
Children: []*v1alpha1.TopologyZone{
216+
{
217+
Type: "Numa",
218+
Name: "0",
219+
Resources: v1alpha1.Resources{
220+
Allocatable: &v1.ResourceList{
221+
consts.ReclaimedResourceMilliCPU: resource.MustParse("10000"),
222+
},
223+
},
224+
},
225+
},
226+
},
227+
},
193228
},
194229
},
195230
reclaimedResourceConfiguration: &reclaimedresource.ReclaimedResourceConfiguration{
@@ -296,6 +331,23 @@ func TestHeadroomAssemblerCommon_GetHeadroom(t *testing.T) {
296331
consts.ReclaimedResourceMilliCPU: resource.MustParse("10000"),
297332
},
298333
},
334+
TopologyZone: []*v1alpha1.TopologyZone{
335+
{
336+
Type: "Socket",
337+
Name: "0",
338+
Children: []*v1alpha1.TopologyZone{
339+
{
340+
Type: "Numa",
341+
Name: "0",
342+
Resources: v1alpha1.Resources{
343+
Allocatable: &v1.ResourceList{
344+
consts.ReclaimedResourceMilliCPU: resource.MustParse("10000"),
345+
},
346+
},
347+
},
348+
},
349+
},
350+
},
299351
},
300352
},
301353
reclaimedResourceConfiguration: &reclaimedresource.ReclaimedResourceConfiguration{
@@ -344,6 +396,23 @@ func TestHeadroomAssemblerCommon_GetHeadroom(t *testing.T) {
344396
consts.ReclaimedResourceMilliCPU: resource.MustParse("15000"),
345397
},
346398
},
399+
TopologyZone: []*v1alpha1.TopologyZone{
400+
{
401+
Type: "Socket",
402+
Name: "0",
403+
Children: []*v1alpha1.TopologyZone{
404+
{
405+
Type: "Numa",
406+
Name: "0",
407+
Resources: v1alpha1.Resources{
408+
Allocatable: &v1.ResourceList{
409+
consts.ReclaimedResourceMilliCPU: resource.MustParse("15000"),
410+
},
411+
},
412+
},
413+
},
414+
},
415+
},
347416
},
348417
},
349418
reclaimedResourceConfiguration: &reclaimedresource.ReclaimedResourceConfiguration{
@@ -392,6 +461,32 @@ func TestHeadroomAssemblerCommon_GetHeadroom(t *testing.T) {
392461
consts.ReclaimedResourceMilliCPU: resource.MustParse("86000"),
393462
},
394463
},
464+
TopologyZone: []*v1alpha1.TopologyZone{
465+
{
466+
Type: "Socket",
467+
Name: "0",
468+
Children: []*v1alpha1.TopologyZone{
469+
{
470+
Type: "Numa",
471+
Name: "0",
472+
Resources: v1alpha1.Resources{
473+
Allocatable: &v1.ResourceList{
474+
consts.ReclaimedResourceMilliCPU: resource.MustParse("43000"),
475+
},
476+
},
477+
},
478+
{
479+
Type: "Numa",
480+
Name: "1",
481+
Resources: v1alpha1.Resources{
482+
Allocatable: &v1.ResourceList{
483+
consts.ReclaimedResourceMilliCPU: resource.MustParse("43000"),
484+
},
485+
},
486+
},
487+
},
488+
},
489+
},
395490
},
396491
},
397492
reclaimedResourceConfiguration: &reclaimedresource.ReclaimedResourceConfiguration{

0 commit comments

Comments
 (0)