Skip to content

Commit 9781d2b

Browse files
committed
Fix re-adding stuff on rebase
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
1 parent 942aeef commit 9781d2b

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

.github/workflows/ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ jobs:
194194
make BASE_IMAGE=registry.k8s.io/ingress-nginx/nginx:${TAGNGINX} clean-image build image image-chroot
195195
make -C test/e2e-image image
196196
cd images/custom-error-pages/rootfs && docker image build \
197-
--build-arg=BASE_IMAGE=registry.k8s.io/ingress-nginx/nginx-1.25:${TAGNGINX} \
197+
--build-arg=BASE_IMAGE=registry.k8s.io/ingress-nginx/nginx:${TAGNGINX} \
198198
--build-arg GOLANG_VERSION=$(cat ../../../GOLANG_VERSION) \
199199
--tag ingress-controller/custom-error-pages:1.0.0-dev . \
200200
&& cd ../../..

.github/workflows/zz-tmpl-k8s-e2e.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ jobs:
4444
SKIP_INGRESS_IMAGE_CREATION: true
4545
SKIP_E2E_IMAGE_CREATION: true
4646
SKIP_CUSTOMERRORPAGES_IMAGE_CREATION: true
47-
ENABLE_VALIDATIONS: ${{ inputs.variation == 'VALIDATIONS' }}
4847
IS_CHROOT: ${{ inputs.variation == 'CHROOT' }}
4948
run: |
5049
kind get kubeconfig > $HOME/.kube/kind-config-kind

images/Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ EXTRAARGS ?= $(shell cat $(NAME)/EXTRAARGS)
4141
export DOCKER_CLI_EXPERIMENTAL=enabled
4242

4343
# build with buildx
44-
BUILDX_PLATFORMS ?= linux/amd64,linux/arm,linux/arm64,linux/s390x
45-
OUTPUT ?=
46-
PROGRESS = plain
44+
PLATFORMS?=linux/amd64,linux/arm,linux/arm64
45+
OUTPUT?=
46+
PROGRESS=plain
4747

4848

4949
precheck:
@@ -58,7 +58,7 @@ build: precheck ensure-buildx
5858
--label=org.opencontainers.image.description="Ingress NGINX $(NAME) image" \
5959
--build-arg BASE_IMAGE=$(BASE_IMAGE) \
6060
--build-arg GOLANG_VERSION=$(GO_VERSION) \
61-
--platform=${BUILDX_PLATFORMS} $(OUTPUT) \
61+
--platform=${PLATFORMS} $(OUTPUT) \
6262
--progress=$(PROGRESS) \
6363
--pull $(EXTRAARGS) \
6464
-t $(IMAGE):$(TAG) $(NAME)/rootfs

0 commit comments

Comments
 (0)