Skip to content

Commit 8ab3577

Browse files
authored
Fix release notes on helm (#10434)
1 parent 82e24cb commit 8ab3577

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

magefiles/steps/helm.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
"bytes"
2121
"fmt"
2222
"os"
23+
"strings"
2324

2425
semver "github.com/blang/semver/v4"
2526
"github.com/helm/helm/pkg/chartutil"
@@ -107,10 +108,10 @@ func updateChartReleaseNotes(releasesNotes []string) {
107108
utils.Info("HELM Updating the Chart Release notes")
108109
chart, err := chartutil.LoadChartfile(HelmChartPath)
109110
utils.CheckIfError(err, "HELM Could not Load Chart to update release notes %s", HelmChartPath)
110-
var releaseNoteString string
111111
for i := range releasesNotes {
112-
releaseNoteString = fmt.Sprintf("%s - \"%s\"\n", releaseNoteString, releasesNotes[i])
112+
releasesNotes[i] = fmt.Sprintf("- %q", releasesNotes[i])
113113
}
114+
releaseNoteString := strings.Join(releasesNotes, "\n")
114115
utils.Info("HELM Release note string %s", releaseNoteString)
115116
chart.Annotations["artifacthub.io/changes"] = releaseNoteString
116117
err = chartutil.SaveChartfile(HelmChartPath, chart)

0 commit comments

Comments
 (0)